----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/#review162894 -----------------------------------------------------------
@ReviewBot retry - Dmitriy Shirchenko On Jan. 25, 2017, 1:34 a.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55902/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2017, 1:34 a.m.) > > > Review request for Aurora, Joshua Cohen and Zameer Manji. > > > Bugs: AURORA-1881 > https://issues.apache.org/jira/browse/AURORA-1881 > > > Repository: aurora > > > Description > ------- > > Users really could really benefit from seeing the output of the shell health > check failure, so plumbing through the output. > > > Diffs > ----- > > src/main/python/apache/aurora/common/health_check/shell.py > 58470a48a7a14092eeb8837aada9e358c6922c93 > src/test/python/apache/aurora/common/health_check/test_shell.py > 792ef40028cda112db5b93c4cc37e305937bc351 > > Diff: https://reviews.apache.org/r/55902/diff/ > > > Testing > ------- > > added unit tests > e2e tests > screenshot attached. > > > File Attachments > ---------------- > > Updated screenshot > > https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png > > > Thanks, > > Dmitriy Shirchenko > >