----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55951/#review163018 -----------------------------------------------------------
The code change itself is fine. However, it's implications are a little bit horrible :) * We can only apply it once we have released 0.17 (build against Mesos 1.1) * Mesos broke +-1 version compatibility here, so users have to update to Thermos 0.18 (i.e. this patch) and Mesos 1.2 at the exact same time. I feel like we should escalate this and ask the Mesos people if they are willing to re-establish compatibility for one version. - Stephan Erb On Jan. 25, 2017, 8:02 p.m., Santhosh Kumar Shanmugham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55951/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2017, 8:02 p.m.) > > > Review request for Aurora, Joshua Cohen, Stephan Erb, and Karthik Anantha > Padmanabhan. > > > Bugs: AURORA-1882 > https://issues.apache.org/jira/browse/AURORA-1882 > > > Repository: aurora > > > Description > ------- > > MesosContainerizer has updated the command line parameters and > consolidated the individual arguments into a single ContainerLaunchInfo > proto buf message. Update ThermosExecutor to use the new `--launch_info` > parameter to be compatible with MesosContainerizer. > > > Diffs > ----- > > build-support/packer/build.sh 548cf37e097c6ed56fc6cc718a642b105afb9331 > src/main/python/apache/thermos/common/process_util.py > 54e716b726fc02f3901f1b9143d3fa253511e29b > src/test/python/apache/thermos/core/test_process.py > 520390217f691b9136cb4d36262be3d372a16509 > > Diff: https://reviews.apache.org/r/55951/diff/ > > > Testing > ------- > > build-support/jenkins/build.sh > > TBD: End-to-end test needs Mesos 1.2.0 which has not been released? > > > Thanks, > > Santhosh Kumar Shanmugham > >
