----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56058/#review163518 -----------------------------------------------------------
Ship it! - Pradyumna Kaushik On Jan. 30, 2017, 12:55 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56058/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2017, 12:55 p.m.) > > > Review request for Aurora, Pradyumna Kaushik and Santhosh Kumar Shanmugham. > > > Bugs: AURORA-1879 > https://issues.apache.org/jira/browse/AURORA-1879 > > > Repository: aurora > > > Description > ------- > > Central idea of this patch is to change the return value of > `getPendingReasons` from a map keyed by JobKey to a map keyed by > `TaskGroupKey`. This prevents the `IllegalArgumentException` during the map > construction. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java > 457107090351330e68941b039ce87b9a3a124971 > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java > 1c015a20853b1bc02033bdc925d3d8fc55896de1 > src/test/java/org/apache/aurora/scheduler/http/PendingTasksTest.java > b71669f7aed58ea87bd3a23e45ff74efa1420aec > src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java > 195d083166edcb0531b221dc5088216bd6a387f3 > > Diff: https://reviews.apache.org/r/56058/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > >
