----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56797/#review166007 -----------------------------------------------------------
Ship it! Ship It! - Zameer Manji On Feb. 17, 2017, 4:13 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56797/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2017, 4:13 p.m.) > > > Review request for Aurora, Mehrdad Nurolahzade and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > This is a small change to relieve GC pressure while explicit reconciliation > runs. It moves the IScheduledTask -> TaskStatus conversion into the batch > processing closure so that any object allocation and collection overhead is > delayed until the batch is actually processed. It has a noticable effect on > GC for large amounts of RUNNING tasks. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java > ec7ccafcd360c00beceb067963bc430b6b8d8256 > > Diff: https://reviews.apache.org/r/56797/diff/ > > > Testing > ------- > > This is running in prod at Twitter. Our post-snapshot stop the world GC hit > is reduced dramatically maybe about 80% of the time with this change. > > > Thanks, > > David McLaughlin > >
