> On Feb. 24, 2017, 3:18 p.m., David McLaughlin wrote: > > Do we have PMC members/committers who are comfortable with accepting major > > feature changes in this manner? This feature proposal has been around for a > > while, and the last time we left it, we were waiting on more iterations on > > the design doc. All that seems to have happened is just a follow-up review > > with the PoC code dump. I'm not trying to be difficult, but I really don't > > think code reviews are a good format for discussing the different > > trade-offs and user experience of features of this magnitude. > > > > I am voting -1 to accepting these two patches.
David, I am a PMC member and a committer and I'm not sure what you mean by "major feature changes in this manner". If I recall correctly there is a design doc [here]. The code here coressponds to the "OfferReconciler" section in the document. I believe there was some consensus between folks on this document before. Is this not the case? [here]: https://docs.google.com/document/d/1L2EKEcKKBPmuxRviSUebyuqiNwaO-2hsITBjt3SgWvE/edit# - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56691/#review166781 ----------------------------------------------------------- On Feb. 24, 2017, 3:02 p.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56691/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2017, 3:02 p.m.) > > > Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji. > > > Bugs: AURORA-1816 > https://issues.apache.org/jira/browse/AURORA-1816 > > > Repository: aurora > > > Description > ------- > > Second patch that implements mechanism for unreserving previously reserved > resources for dynamic reservations proposal. > > > Diffs > ----- > > src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java > 6f2ca35c5d83dde29c24865b4826d4932e96da80 > src/main/java/org/apache/aurora/scheduler/HostOffer.java > 23f0600d64e1e15f4856f397e839e3d1c87f3b96 > src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java > b12ac83168401c15fb1d30179ea8e4816f09cd3d > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java > 0637eb7f85125cf70b588d56fa7dc88130947837 > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > 8c000cb0626bd34f6f30e23fe2b3a045f2b44e35 > src/main/java/org/apache/aurora/scheduler/offers/OfferReconciler.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java > 202cae96ffc5b49e638b973a273f7983137b5baf > src/test/java/org/apache/aurora/scheduler/http/OffersTest.java > 30699596a1c95199df7504f62c5c18cab1be1c6c > src/test/java/org/apache/aurora/scheduler/offers/HostOffers.java > PRE-CREATION > src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java > 49d4e82cc03144b80292fe43066a6cc4d7aed88f > src/test/java/org/apache/aurora/scheduler/offers/OfferReconcilerTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56691/diff/ > > > Testing > ------- > > Ran locally on vagrant. > > > Thanks, > > Dmitriy Shirchenko > >
