----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37855/#review172217 -----------------------------------------------------------
At this point, I feel like it will be easier to start over with the renaming. Closing. - Stephan Erb On Aug. 27, 2015, 11:12 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37855/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 11:12 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1453 > https://issues.apache.org/jira/browse/AURORA-1453 > > > Repository: aurora > > > Description > ------- > > Rename slave to agent in scheduler src/main/java. > > First patch of about 3. This updates all internal references in the scheduler > to use the term "Mesos Agent" instead of "Mesos Slave". Changed everything > here that doesn't rely on an external API. This changes all JavaDoc, > comments, log messages, and scheduler-private variable names. The only places > not changed are those where the name is defined by an external API > (specifically, `mesos.proto`, `SchedulerDriver.java`, and `api.thrift`). > > This change introduces a new `agent_id` key in the `Offer` struct, but > preserves the `slave_id` key for backwards compatibility. > > For confidence and ease of review I will change DbStorage references (Mybatis > XML+interface matching) and `src/test/java` in separate reviews. > > > Diffs > ----- > > src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java > fbd24ea4a58e28c14a343170de137c0e0ae437a2 > src/main/java/org/apache/aurora/scheduler/Resources.java > 712876e1fe2bfb02cb147cd7674a84dd220de899 > src/main/java/org/apache/aurora/scheduler/base/Conversions.java > ad66cd86567497dc3e75d75e278540c75b88d89d > src/main/java/org/apache/aurora/scheduler/base/Query.java > 458530fb216fd37048d3e398c07b147a1a71cf57 > src/main/java/org/apache/aurora/scheduler/base/Tasks.java > 9f625c775544d9ae4d8e5b15e1fc824ed4a876c8 > src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java > 51376798d3e4fb7c86802e4afbe7f2c7191c0e72 > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java > fb0f7ccf7f4dfb3ccb2a4cb4a5643c4b5487ff8f > src/main/java/org/apache/aurora/scheduler/http/Maintenance.java > 526875906adfec94bdb3aadfb045bdac942ed483 > src/main/java/org/apache/aurora/scheduler/http/Offers.java > 4329ce10189df41a7a45cd6cc369333d7d5f65b0 > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java > 68aeda1692271841d10e5f29d439806576bd691c > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java > 0743cb09bc9ec5375513ac89227c7d839f197324 > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > ed639b6c20a3a51aa829cacb8e5b30265600c9cd > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > 88c9f667b7abc79f6cbedb575b631b68112c1d74 > src/main/java/org/apache/aurora/scheduler/preemptor/ClusterState.java > ce3bc7e6da3f86625c690e26c28ccef67ed9021a > src/main/java/org/apache/aurora/scheduler/preemptor/ClusterStateImpl.java > 42e2ca49b3c5de997cb5363e3518512d0f5a725e > > src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java > 506176769e172b7e9f4ba05c486fe6ab550fb5c3 > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionProposal.java > d598b02b68c5d67610004cbd5eeefab2e9658b69 > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java > 8f3161acdab0e2d25403ee224cd6468327ee956f > > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java > 67d7f072de045d4211b6239119802473278d6419 > src/main/java/org/apache/aurora/scheduler/preemptor/Preemptor.java > 7d2903a47dacfc35f9e547ccb6c5896efe3e013f > > src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java > c797914ded51cd123dddef188373fe58e190773a > src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java > 577edcbf362493d577e2f12c876f1dbb9387ad79 > src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java > f1b11d6513546231c2510805e4a0acf23367a761 > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java > 617ee549cc79f3c95c70ceaceca6e26ccebd1681 > src/main/java/org/apache/aurora/scheduler/state/StateManager.java > 5d34fe38492cae3f50ea9ed0baca11472295af60 > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > f27c93b2a59d9efd4ed8ba0fd314a33e67a9c8e0 > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java > de7ebb382f56854dc2315d3793217ef007d7fbfe > src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java > 981bdcf665fdfa710608c57e7b7817d286dab373 > src/main/java/org/apache/aurora/scheduler/storage/db/AttributeMapper.java > a454887c27dfc80d753afb2b2c4b20fd330aea59 > src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java > ee3ff6cb9f4cec06a5ae4e4fd0a0f8d7ae663176 > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java > ad78432a6595d32582cb0e920900e4bcb21df8dc > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java > 7f0cb5c7f30883982ea9388bf6a6195705dfdd75 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > 072fe459e1422d6d59499b17440232ab112254ba > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java > 3d89e43659750de63d7588f8574e7a350caea04b > src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java > de4fbbcc929a80cdbd3b6593ad4fedce18a88057 > > src/test/java/org/apache/aurora/scheduler/preemptor/ClusterStateImplTest.java > a1ac922d471013779710e02c0c9ca9f84b506807 > > src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java > 9213b88ab4ce5063ca0fb055851ae5632616155e > > src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java > 1308a1c9884e7759e6139787710b367bbf9cd4e9 > > src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java > 13c9f47941eb8ce6c79f3f1a7c530150e3e6fae2 > > src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java > 092df8cdb7901e045682d0f252109a08afc50c01 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > bc3f364a8d49c0b8efb1164efedd6e0a8e9182c8 > > src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java > 4d4e752088f7dca99675cc66782ae046bbd516d6 > > > Diff: https://reviews.apache.org/r/37855/diff/1/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Kevin Sweeney > >
