----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60350/#review178709 -----------------------------------------------------------
Ship it! Ship It! - David McLaughlin On June 22, 2017, 12:16 a.m., Kai Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60350/ > ----------------------------------------------------------- > > (Updated June 22, 2017, 12:16 a.m.) > > > Review request for Aurora, David McLaughlin, Santhosh Kumar, and Zameer Manji. > > > Bugs: AURORA-1937 > https://issues.apache.org/jira/browse/AURORA-1937 > > > Repository: aurora > > > Description > ------- > > *Add missing stats in MesosCallbackHandler. > > We are thinking about switching to a new driver implementation around V1Mesos > (https://reviews.apache.org/r/57061). The V1 Mesos code requires a Scheduler > callback with a different API. To maximize code reuse, event handling logic > was extracted into a MesosCallbackHandler class. However, two metrics for > handling __task status update__, and for handling __framework message__ are > missing in this class. > > This CR adds the two missing stats in the MesosCallbackHandler class. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java > 772a04cbad99eb088105822f41b0758f47f7915a > > src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java > b955d61bbed2a6f4cb7f2581ebec398d637f0895 > > > Diff: https://reviews.apache.org/r/60350/diff/1/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > > Thanks, > > Kai Huang > >
