----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62601/#review186357 -----------------------------------------------------------
Ship it! Master (79ff364) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Sept. 27, 2017, 12:20 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62601/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2017, 12:20 a.m.) > > > Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb. > > > Repository: aurora > > > Description > ------- > > Consider this somewhere between 'proposal' and 'discussion starter'. I think > this behavior should die, reasons noted in `RELEASE-NOTES.md`. Normally i > would support a deprecation cycle, but i think this is safe to short-circuit > due to the obscurity (no tools provided that use this, no documentation, no > known uses) along with the inherent riskiness of using it. > > > Diffs > ----- > > RELEASE-NOTES.md fd2618fee8ef05091849e177bd99fc321548be90 > api/src/main/thrift/org/apache/aurora/gen/api.thrift > 3749531b5412d7ca217736aa85eed8e6606225ad > api/src/main/thrift/org/apache/aurora/gen/storage.thrift > 9e4213f13255a182df938bea44ca87fa03a25318 > src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java > 1094a122fe836e53d0481ee5c097447f1e91fa0a > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java > 5af1a798db659f1934ab35bb6a77afaa4b45b47c > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java > 387350c7667a5fb8ee674ad0d3dd17529232b25b > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > d0de063fd78e6c4f62fae4a598d1d22f9775772d > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > 964e2fc82eca5b3a40ce4419c5de80bdea32fa72 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 7ea6fc4c7667270541cd964eb39446bc9af3c796 > src/main/python/apache/aurora/client/api/__init__.py > 7efafd3f0124e453f68f29861fc4ca444e19abde > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > 69c35b1fb4da052243e5022f3bbc2ec186f1d216 > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > 0eb54fdaddfbc2af76fd83ffee18ce4c6b61cc48 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 9c446682750706aecdc67062ae82f2a76ab38043 > src/test/python/apache/aurora/client/api/test_scheduler_client.py > b2fd4d929227124c5fdce24dac38488b8ec66bdd > > > Diff: https://reviews.apache.org/r/62601/diff/2/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
