----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62451/#review186511 -----------------------------------------------------------
Ship it! LGTM - Kai Huang On Sept. 28, 2017, 12:18 a.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62451/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2017, 12:18 a.m.) > > > Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar > Shanmugham. > > > Repository: aurora > > > Description > ------- > > Implement Role and Environment pages in Preact. The color scheme and other > design elements aren't final yet - the plan is to wait until the structure is > all in place and then go back and style things. > > Major difference from the current UI is the use of color to visualize the > task states and the move away from the table format of the data. > > > Diffs > ----- > > ui/src/main/js/components/JobList.js PRE-CREATION > ui/src/main/js/components/JobListItem.js PRE-CREATION > ui/src/main/js/components/Layout.js PRE-CREATION > ui/src/main/js/components/Pagination.js > dec89be93d531f755097ac8b3ee48d643d31262f > ui/src/main/js/components/RoleQuota.js PRE-CREATION > ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION > ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION > ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 > ui/src/main/js/pages/Jobs.js PRE-CREATION > ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION > ui/src/main/js/utils/Common.js PRE-CREATION > ui/src/main/js/utils/Job.js PRE-CREATION > ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 > ui/src/main/sass/components/_job-list-page.scss PRE-CREATION > ui/src/main/sass/components/_layout.scss > b8a83b585fcef11964dc8349703ad453d37b5d2d > ui/src/main/sass/components/_tables.scss > 2ea60bc64ccb2b556ef6edf25016f6a01cd075f6 > ui/src/main/sass/modules/_colors.scss > 147cff691058972aebc5f79f22955cf2448ce48c > > > Diff: https://reviews.apache.org/r/62451/diff/3/ > > > Testing > ------- > > ./gradlew ui:test > ./gradlew ui:lint > > See screenshot for local development with some Twitter data. > > > File Attachments > ---------------- > > Screenshot > > https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png > > > Thanks, > > David McLaughlin > >
