----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62835/ -----------------------------------------------------------
Review request for Aurora, John Sirois and Bill Farner. Repository: aurora Description ------- Curator will warn if used with a connection timeout that is lower than the session timeout [1]. As it uses a default connection timeout of 15s [2], this warning will be emitted using the Aurora default settings. This patch remedies this issue in two ways: * Making the Curator connection timeout configurable * Bumping the session timeout to 15s. The current default of 4s is pretty small and could lead to unexpected failovers during long GC pauses. This is especially problematic as a failover in Aurora can be lengthy. [1] https://github.com/apache/curator/blob/15eb063fa22569e797f850fb8d60a0949f52fbf5/curator-client/src/main/java/org/apache/curator/CuratorZookeeperClient.java#L118-L121 [2] https://github.com/apache/curator/blob/6ba4de36d4e8b2b65d45c005a6a92dd85c3c497f/curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java#L60-L61 Diffs ----- commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 2ada2646da7bdc3276803336cc638e23b9e61d26 src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java ea167a89a95f0f35d53a34631ae44e0a911a6817 src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java e8aafe4a47e3f0e6312c8b93dbc32e1c25445dd3 src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 4014a91299d863337c5f58a0495775c5f4aa6c09 src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java 0f2121ef1453b41286f9713d5ce89a26d1cb1b4f src/test/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfigTest.java a065505134c1ad30ba9f4d4cd829355b2acc9a13 Diff: https://reviews.apache.org/r/62835/diff/1/ Testing ------- ./gradlew -Pq build Thanks, Stephan Erb
