----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62763/ -----------------------------------------------------------
(Updated Oct. 10, 2017, 5:02 p.m.) Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham. Changes ------- feedback. Repository: aurora Description ------- Implement update page for new UI. The most significant change here is the performance - for our jobs at Twitter with thousands of instances, this shaves tens of seconds off the render time compared to the Angular version (which I think is attributed to the tooltip code). I translated the "instance events" into something useful - now grouping them all events for an instance together in a single item and showing history with the state machine component. For the instance visualization, I also simplified the color scheme. There is now only: success, error, warning, in progress and removed. So no more roll backs being represented as green boxes with red borders (roll backs are now considered as the warning/attention color). I didn't do much for configuration and kept the UX the same as the existing UI, I will tackle showing diffs in the future. This is branched off of https://reviews.apache.org/r/62720 Diffs (updated) ----- ui/.eslintrc 84a6d37d8a643047f97a03187fae1b3616633650 ui/package.json 6e8ad7a3f7a5d6c450ded4e2c1f216cfa4551a2c ui/src/main/js/components/InstanceViz.js PRE-CREATION ui/src/main/js/components/Layout.js 50d63e6252b38cf26688ab032409a00082561f14 ui/src/main/js/components/Pagination.js 7bf2c04e2b879657c6ec43d261f2512fae79a08e ui/src/main/js/components/TaskConfig.js PRE-CREATION ui/src/main/js/components/Time.js PRE-CREATION ui/src/main/js/components/UpdateConfig.js PRE-CREATION ui/src/main/js/components/UpdateDetails.js PRE-CREATION ui/src/main/js/components/UpdateInstanceEvents.js PRE-CREATION ui/src/main/js/components/UpdateInstanceSummary.js PRE-CREATION ui/src/main/js/components/UpdateList.js PRE-CREATION ui/src/main/js/components/UpdateSettings.js PRE-CREATION ui/src/main/js/components/UpdateStateMachine.js PRE-CREATION ui/src/main/js/components/UpdateStatus.js PRE-CREATION ui/src/main/js/components/UpdateTime.js PRE-CREATION ui/src/main/js/components/UpdateTitle.js PRE-CREATION ui/src/main/js/components/__tests__/InstanceViz-test.js PRE-CREATION ui/src/main/js/components/__tests__/Pagination-test.js f2b72e93eabe9660f3ca54d3e151ce154fa81e0a ui/src/main/js/components/__tests__/UpdateInstanceEvents-test.js PRE-CREATION ui/src/main/js/components/__tests__/UpdateList-test.js PRE-CREATION ui/src/main/js/components/__tests__/UpdateStatus-test.js PRE-CREATION ui/src/main/js/index.js 8f077341b2194fc00d202b0eb289b23986d0f2e0 ui/src/main/js/pages/Update.js PRE-CREATION ui/src/main/js/pages/Updates.js PRE-CREATION ui/src/main/js/pages/__tests__/Update-test.js PRE-CREATION ui/src/main/js/pages/__tests__/Updates-test.js PRE-CREATION ui/src/main/js/test-utils/UpdateBuilders.js PRE-CREATION ui/src/main/js/utils/Common.js be8766c3b53943dcf094670019ec528975dc05b5 ui/src/main/js/utils/Thrift.js b247e36dfa7e8b686e8e6caccfec9ff813829bab ui/src/main/js/utils/Update.js PRE-CREATION ui/src/main/js/utils/__tests__/Update-test.js PRE-CREATION ui/src/main/sass/app.scss e301d4c31baed10faf06d84f30d1c1dbce66952a ui/src/main/sass/components/_instance-viz.scss PRE-CREATION ui/src/main/sass/components/_layout.scss 4ebec0532550a0c6084fb603cfab5789c1ccb371 ui/src/main/sass/components/_update-list.scss PRE-CREATION ui/src/main/sass/components/_update-page.scss PRE-CREATION ui/test-setup.js a403434ddd7d6b33b7e18ca8c25ab68707a35fd8 Diff: https://reviews.apache.org/r/62763/diff/3/ Changes: https://reviews.apache.org/r/62763/diff/2-3/ Testing ------- ./gradlew ui:lint ./gradlew ui:test Tested against live APIs. Note: I am pushing small nitpick bugs to the very end of this work (where we will leverage internal beta-testing). File Attachments ---------------- Successful update https://reviews.apache.org/media/uploaded/files/2017/10/05/457b8fe0-dfd4-4e30-bbd3-e5c76906fab2__Screen_Shot_2017-10-04_at_5.22.08_PM.png Update In-Progress https://reviews.apache.org/media/uploaded/files/2017/10/05/d04afb4c-7110-4fe2-a0d9-c191b935a555__Screen_Shot_2017-10-04_at_5.25.40_PM.png Huge update https://reviews.apache.org/media/uploaded/files/2017/10/05/5b2534e3-e5d6-48e8-9615-2b1f7bb13617__Screen_Shot_2017-10-04_at_5.27.15_PM.png Thanks, David McLaughlin
