----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62873/#review187585 -----------------------------------------------------------
Master (4a1fba3) is red with this patch. ./build-support/jenkins/build.sh # INFO: os::commit_memory(0x00000007b1100000, 248512512, 0) failed; error='Cannot allocate memory' (errno=12) # There is insufficient memory for the Java Runtime Environment to continue. # Native memory allocation (mmap) failed to map 248512512 bytes for committing reserved memory. # An error report file with more information is saved as: # /home/jenkins/jenkins-slave/workspace/AuroraBot/hs_err_pid2009.log :test FAILED :jacocoTestReport Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html :jacocoTestCoverageVerification[ant:jacocoReport] Rule violated for bundle aurora: instructions covered ratio is 0.76, but expected minimum is 0.87 [ant:jacocoReport] Rule violated for bundle aurora: branches covered ratio is 0.65, but expected minimum is 0.79 FAILED FAILURE: Build completed with 2 failures. 1: Task failed with an exception. ----------- * What went wrong: Execution failed for task ':test'. > Process 'Gradle Test Executor 8' finished with non-zero exit value 1 * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. ============================================================================== 2: Task failed with an exception. ----------- * What went wrong: Execution failed for task ':jacocoTestCoverageVerification'. > Rule violated for bundle aurora: instructions covered ratio is 0.76, but > expected minimum is 0.87 Rule violated for bundle aurora: branches covered ratio is 0.65, but expected minimum is 0.79 * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. ============================================================================== * Get more help at https://help.gradle.org BUILD FAILED in 9m 26s 50 actionable tasks: 41 executed, 9 up-to-date I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 10, 2017, 4:35 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62873/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2017, 4:35 p.m.) > > > Review request for Aurora and Jordan Ly. > > > Repository: aurora > > > Description > ------- > > This reduces the memory burden of loading a backup for recovery. Previously, > the backup file would be fully loaded into a `byte[]`, which may be very > large and fail to allocate. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java > b74de9b51fd01788a3970e56a534a3b9adcd8863 > > > Diff: https://reviews.apache.org/r/62873/diff/1/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
