----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62958/#review188181 -----------------------------------------------------------
Ship it! LGTM - Kai Huang On Oct. 13, 2017, 12:10 a.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62958/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2017, 12:10 a.m.) > > > Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar > Shanmugham. > > > Repository: aurora > > > Description > ------- > > This maintains the existing UI functionality where clicking on tabs updates > the browser location, to create shareable URLs to tab views. > > > Diffs > ----- > > ui/package.json cde8d106346d9ac498cfee9b5291ebc637fc6a2a > ui/src/main/js/components/Tabs.js 43b1950b11b80dc3017730801992341bc527c39c > ui/src/main/js/components/__tests__/Tabs-test.js > e028c2dd86739ed9762aa1d0be5c609d5487e06e > ui/src/main/js/pages/Job.js fc400f7442a1f8a5f0ebfe366dfe40ef40e7108e > ui/src/main/js/pages/__tests__/Job-test.js > 4cc76b8731d71ceca87a5d1e259360b2af8feba0 > > > Diff: https://reviews.apache.org/r/62958/diff/1/ > > > Testing > ------- > > ./gradlew ui:lint > ./gradlew ui:test > > Unfortunately the testing here is only on one side (restoring the URL state). > I cannot simulate the change events from the unit tests because of > limitations with shallow rendering. When I figure out how to add integration > tests that work with React Router, I'll add coverage. > > > Thanks, > > David McLaughlin > >
