----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63135/#review188636 -----------------------------------------------------------
Master (0622f34) is red with this patch. ./build-support/jenkins/build.sh org.apache.aurora.scheduler.events.WebhookTest > testTaskChangedWithOldStateError FAILED java.lang.AssertionError at WebhookTest.java:203 I1019 04:09:16.812 [ShutdownHook, SchedulerMain] Stopping scheduler services. 852 tests completed, 1 failed, 1 skipped :test FAILED :jacocoTestReport Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html :jacocoTestCoverageVerification[ant:jacocoReport] Rule violated for bundle aurora: instructions covered ratio is 0.77, but expected minimum is 0.87 [ant:jacocoReport] Rule violated for bundle aurora: branches covered ratio is 0.65, but expected minimum is 0.79 FAILED FAILURE: Build completed with 2 failures. 1: Task failed with an exception. ----------- * What went wrong: Execution failed for task ':test'. > Process 'Gradle Test Executor 6' finished with non-zero exit value 1 * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. ============================================================================== 2: Task failed with an exception. ----------- * What went wrong: Execution failed for task ':jacocoTestCoverageVerification'. > Rule violated for bundle aurora: instructions covered ratio is 0.77, but > expected minimum is 0.87 Rule violated for bundle aurora: branches covered ratio is 0.65, but expected minimum is 0.79 * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. ============================================================================== * Get more help at https://help.gradle.org BUILD FAILED in 8m 3s 48 actionable tasks: 39 executed, 9 up-to-date I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 19, 2017, 4 a.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63135/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2017, 4 a.m.) > > > Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > ------- > > Refactor Job Page to create cleaner abstractions. Also refactors Tabs to make > them easier to write tests for (using shallow from enzyme). > > Also improved Pagination code (was generating a warning) now that React can > handle returning null from components (and doing the right thing). > > > Diffs > ----- > > ui/src/main/js/components/JobHistory.js PRE-CREATION > ui/src/main/js/components/JobOverview.js PRE-CREATION > ui/src/main/js/components/JobStatus.js PRE-CREATION > ui/src/main/js/components/Pagination.js > 094ef2b248bd802ec63f562a978fd1b4d4bb5eb8 > ui/src/main/js/components/Tabs.js e382aa74e0f73e78c8092a58a605bffc54d15a81 > ui/src/main/js/components/__tests__/JobHistory-test.js PRE-CREATION > ui/src/main/js/components/__tests__/JobStatus-test.js PRE-CREATION > ui/src/main/js/components/__tests__/Tabs-test.js > 252e5e001478b5a727e208b6b2d09d10128e83b9 > ui/src/main/js/pages/Job.js 070f1e43e4fe9c9eac688a9514c14e3296ef41af > ui/src/main/js/pages/__tests__/Job-test.js > 03ef20ddefcc915ed4bd6242de3fe8686efdc202 > > > Diff: https://reviews.apache.org/r/63135/diff/1/ > > > Testing > ------- > > ./gradlew ui:lint > ./gradlew ui:test > > > Thanks, > > David McLaughlin > >