----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63197/#review188948 -----------------------------------------------------------
Ship it! Ship It! - Kai Huang On Oct. 21, 2017, 1:34 a.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63197/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2017, 1:34 a.m.) > > > Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > ------- > > The Tabs component manages its own state, and the parent component controls > the activeTab based on the URL by setting the 'activeTab' property. So we > need to listen to changes to the property (and to the state) in order to > support back (and forward) button. > > FWIW, this is the type of problem that disappears with the bloated and > complex Redux style architecture. > > > Diffs > ----- > > ui/src/main/js/components/Tabs.js a48c600ddea38481fbfc4e6af4f42ed1fb834287 > > > Diff: https://reviews.apache.org/r/63197/diff/1/ > > > Testing > ------- > > Tested in Vagrant and confirmed back button now works. > > > Thanks, > > David McLaughlin > >
