> On May 16, 2018, 1:22 p.m., Stephan Erb wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > > Lines 263 (patched) > > <https://reviews.apache.org/r/67141/diff/1/?file=2023574#file2023574line263> > > > > Just by looking at this it is not clear what `statusKey` means. Maybe > > you can extend the doc string?
Done. > On May 16, 2018, 1:22 p.m., Stephan Erb wrote: > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > > Lines 901 (patched) > > <https://reviews.apache.org/r/67141/diff/1/?file=2023574#file2023574line901> > > > > In most other places in the API timestamps are called out as such. > > Maybe for consistency we should rename `creationTimeMs` to > > `createdTimestampMs` (e.g. as in `JobUpdateState`)? > > > > (I don't feel strongly about this though) Done. > On May 16, 2018, 1:22 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/storage/durability/Loader.java > > Lines 57-65 (original), 58-66 (patched) > > <https://reviews.apache.org/r/67141/diff/1/?file=2023579#file2023579line58> > > > > This is missing the `HostMaintenance` store Done. > On May 16, 2018, 1:22 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/storage/durability/WriteRecorder.java > > Lines 257-258 (patched) > > <https://reviews.apache.org/r/67141/diff/1/?file=2023580#file2023580line257> > > > > If we use a feature toggle here operators can enable the backwards > > incompatible change after they have vetted the release (i.e. once they are > > sure they don't need to do a rollback for unrelated issues). > > > > We can then simply enable the feature toggle by default after next > > release. > > > > @Jordan Ly, would this address your backwards incompatibility concerns? > > Jordan Ly wrote: > I realize that they can just remove all `HostMaintenanceRequest` and > perform a snapshot if they want to rollback to the previous version (kinda > like what they did for 0.14 GPU resources > https://github.com/apache/aurora/blob/master/RELEASE-NOTES.md#0140). I don't > have any concerns going forward with what is present. > > Stephan Erb wrote: > Ah good catch! I will add the RELEASE-NOTES entry in the next patch and include similar instructions for rollback. - Santhosh Kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67141/#review203269 ----------------------------------------------------------- On May 15, 2018, 2:15 p.m., Santhosh Kumar Shanmugham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67141/ > ----------------------------------------------------------- > > (Updated May 15, 2018, 2:15 p.m.) > > > Review request for Aurora, David McLaughlin, Jordan Ly, Renan DelValle, and > Stephan Erb. > > > Bugs: AURORA-1977 > https://issues.apache.org/jira/browse/AURORA-1977 > > > Repository: aurora > > > Description > ------- > > Add `SlaPolicy` and `HostMaintenanceRequest` structs > to the thrift definition and introduce a new `HostMaintenanceStore` > for tracking maintenance requests. These changes will be used in > https://reviews.apache.org/r/66716 for implementing custom SLA > and scheduler driven maintenance. > > This RB splits the storage related changes from > https://reviews.apache.org/r/66716 > for better rollback story. > > Tested rollback on the vagrant. > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > ef754e32172e7490a47a13e7b526f243ffa3efeb > api/src/main/thrift/org/apache/aurora/gen/storage.thrift > b79e2045ccda05d5058565f81988dfe33feea8f1 > src/main/java/org/apache/aurora/scheduler/storage/HostMaintenanceStore.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/Storage.java > da5534f886e032ca5a182f3704aa335ff680b258 > > src/main/java/org/apache/aurora/scheduler/storage/durability/DurableStorage.java > f1fdc275d3958a36bbe79110d70dfeba640a948a > src/main/java/org/apache/aurora/scheduler/storage/durability/Loader.java > 10864f122eff5027c88d835baae6de483d960218 > > src/main/java/org/apache/aurora/scheduler/storage/durability/WriteRecorder.java > 8d70cae35289a9e36142bab288cf0c9398ebd2d4 > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotService.java > b30de881eafa3226fdc32383b4e9bfd33ca912a5 > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotterImpl.java > 4b52be02001e704f4b1a5f447226ac8c2386e3fd > > src/main/java/org/apache/aurora/scheduler/storage/mem/MemHostMaintenanceStore.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java > 9f324b010db7e351e98b257d8fc8fecfeac81268 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java > edcea09b4d206cfddb642074237b031ad71cff13 > src/main/python/apache/aurora/config/schema/base.py > a629bcd1261e5959da0a8458a55545d4e2c2a7a5 > src/main/python/apache/aurora/config/thrift.py > 6d2dde6e964daa68bf6f0e5bbbffecc5bd8c0431 > src/main/python/apache/aurora/executor/executor_vars.py > 561f9452aedda4cc695c84a2a850bdd7e1d65dec > src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 778148a7c033cba9004954cabc33a2b1d003dccf > > src/test/java/org/apache/aurora/scheduler/storage/AbstractHostMaintenanceStoreTest.java > PRE-CREATION > src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java > ba03ff94bb5fee2b09a6660a9ad759cece7449f1 > > src/test/java/org/apache/aurora/scheduler/storage/durability/DataCompatibilityTest.java > 31f9545d83a950064df646ef6ba8a95234cf89ec > > src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java > 3dd9ce4039b223cb6156462d089f7062a1cde772 > > src/test/java/org/apache/aurora/scheduler/storage/durability/WriteRecorderTest.java > 27c8c829cd1e417dd5e60a8e9415331ca4a7c918 > > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotterImplIT.java > be07361a27afefa21cc2ba76ce82531a418d9814 > > src/test/java/org/apache/aurora/scheduler/storage/mem/MemHostMaintenanceStoreTest.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > d59118be13342da9003b0bcb97e12e477d9edf8f > src/test/python/apache/aurora/client/cli/test_inspect.py > e4f43d0573c7862adc9bc679f4cea40cc76eac38 > src/test/python/apache/aurora/config/test_thrift.py > 8e1d0e177959af12b97bdd1cd47845b72bc12fe1 > > src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/removeHostMaintenanceRequest > PRE-CREATION > > src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveCronJob > 88e1c36a1aa2d192b95963f7aa36e243a447e4af > > src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveHostMaintenanceRequest > PRE-CREATION > > src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate > 32fdcdacde58345cdd6c4b449b82c0c90c2b2aae > > src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveTasks > 4323031ec6bd128576c2a43ebc11f04a9f046e2f > > src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/read-compatible/16-saveHostMaintenanceRequest > PRE-CREATION > > src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/read-compatible/17-removeHostMaintenanceRequest > PRE-CREATION > > > Diff: https://reviews.apache.org/r/67141/diff/1/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > > Thanks, > > Santhosh Kumar Shanmugham > >