----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67613/ -----------------------------------------------------------
(Updated June 15, 2018, 12:58 p.m.) Review request for Aurora, David McLaughlin and Jordan Ly. Changes ------- - add to scheduler active services Bugs: AURORA-1990 https://issues.apache.org/jira/browse/AURORA-1990 Repository: aurora Description ------- Convert SlaManager into an AbstractIdleService and explicitly close the AsyncHttpClient on scheduler shutdown. Otherwise we run the rise of having a stuck scheduler JVM that is unable to shutdown due to any on the remaining non-daemon http client threads. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 5ad12511e3ec7dda227d133b7e0a2063c352c016 src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java 98bec4857f1b3c247c24059150de3e4aac080a02 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 07082a99701ea1e428164e76267b908ae20508ad Diff: https://reviews.apache.org/r/67613/diff/2/ Changes: https://reviews.apache.org/r/67613/diff/1-2/ Testing ------- ./gradlew test Thanks, Santhosh Kumar Shanmugham