----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67696/ -----------------------------------------------------------
(Updated June 22, 2018, 12:50 a.m.) Review request for Aurora, David McLaughlin, Renan DelValle, Santhosh Kumar Shanmugham, and Stephan Erb. Changes ------- Fixing build, small style stuff. Repository: aurora Description ------- This patch enables SLA-aware updates. Following https://reviews.apache.org/r/66716/, tasks may now specify custom SLA policies that will be respected by the scheduler during maintenance. This patch integrates into the same system to allow users to specify if they want their updates to also respect SLA. Please see https://docs.google.com/document/d/1lCoDyoX26qrGrptrgO7vJHqYR_L2CBRGFIywsAd8uQo/edit?usp=sharing for a more detailed description. This patch adds two optional Thrift fields, `slaAware` to `JobUpdateSettings` and `message` to `JobInstanceUpdateEvent`. These should be forward and backwards compatible. Diffs (updated) ----- api/src/main/thrift/org/apache/aurora/gen/api.thrift 7265b11103aa12743c42355163ae64e98e965d7f src/main/java/org/apache/aurora/scheduler/base/Tasks.java 2e13aacf576e648d9fffe989e4fc05c8954e72d8 src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java 9aa51c3637df74cca088bd65c5539e1ebb8e5f0d src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 9fa68b2dd55b4e4f5436356c1b94af1393967679 src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java a002d955c3bc7b7c39da5e130e8c10c536bdcebd src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java ec577cccb86914ebd679ca235103f79dd7e7b79d src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java f2d33fb9ab6bd2c3ff199ab03dc75b1d6d618f3a src/main/java/org/apache/aurora/scheduler/updater/SlaKillController.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 74ee1745e1fd7c308e2bdfa46aeb18a7ecfe14d2 src/main/java/org/apache/aurora/scheduler/updater/Updates.java f949fd54f524780672167e12fcadf268da08e679 src/main/python/apache/aurora/client/api/updater_util.py 4e3986220aaa4c9b138394b962120b176185af12 src/main/python/apache/aurora/config/schema/base.py 7baded79acdf863670afc183d740dcad602490c2 src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java dcf58896f1e866c0369ba1b78060236e98d9d46b src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java 3a06a451da4ef3acccb33b5495b9fae141557148 src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 0aea369d8a8f75291de9691b6d61f3d48895507c src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 43f857d893a54e19e71b36f2f06fef3a3ef6e874 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5667a1b59681a6de87149d7161d760bff5da3818 src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java 2c27ec7136ff22a3570a4ec278c73f7ee310f628 src/test/java/org/apache/aurora/scheduler/updater/SlaKillControllerTest.java PRE-CREATION src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobInstanceUpdateEvent 48902d39b9d2cbeae1a52180669aba8349e4dd65 src/test/resources/org/apache/aurora/scheduler/storage/durability/goldens/current/saveJobUpdate 08dfa5b9a67989083a0d405ce8100698a4d096ae ui/src/main/js/components/UpdateInstanceEvents.js 8351f2c4c256e27625d94b70842be0e91065a551 ui/src/main/js/components/UpdateSettings.js d756f5916fd8c39dcbb5578ee5eda198f807f458 Diff: https://reviews.apache.org/r/67696/diff/2/ Changes: https://reviews.apache.org/r/67696/diff/1-2/ Testing ------- Added unit tests, `./gradlew test`. Tested at scale with over 10,000 SLA-aware instance update events occuring concurrently. Scheduler stability did not seem to be affected. Thanks, Jordan Ly
