----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67967/#review206205 -----------------------------------------------------------
Ship it! Ship It! - David McLaughlin On July 18, 2018, 8:27 p.m., Santhosh Kumar Shanmugham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67967/ > ----------------------------------------------------------- > > (Updated July 18, 2018, 8:27 p.m.) > > > Review request for Aurora, David McLaughlin, Jordan Ly, Reza Motamedi, and > Stephan Erb. > > > Repository: aurora > > > Description > ------- > > If the ThermoTaskRunner encounters an Exception when trying to > fork the process, it bubbles this up to the Executor which does > not handle execptions other than TaskError. This leads to the > executor leaving the task in STARTING state and we end up with > tasks that get stranded in this state. > > Fix it so that any unknown expection that is thrown when starting > a runner leads to task failure and get marked as FAILED. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/aurora_executor.py > 8a9958fffc2312686dccc7daf6d216631d4c956e > src/test/python/apache/aurora/executor/test_thermos_executor.py > f6ae1be5d56bfd845bd09db67ef0000a92091136 > > > Diff: https://reviews.apache.org/r/67967/diff/1/ > > > Testing > ------- > > ./gradlew test > ./pants test src/test/python/apache:: > > > Thanks, > > Santhosh Kumar Shanmugham > >
