----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/#review34509 -----------------------------------------------------------
src/main/python/apache/aurora/client/cli/__init__.py <https://reviews.apache.org/r/17948/#comment64606> minor nit -- we usually prefer never to shadow builtins even though in this case it's harmless. i'd s/str/msg/ just to be consistent with our practices elsewhere. src/main/python/apache/aurora/client/cli/jobs.py <https://reviews.apache.org/r/17948/#comment64609> I'm not sure how I feel about the help property returning manually split doc lines. It probably makes more sense to just return a """docstring""" style string -- which you can then always do .splitlines() on. (Alternately, you can do isinstance(str) elif isinstance(list) I suppose.) At the end of the day, if you end up on smaller or larger terminals, you'll probably end up using the textwrap module to change the line breaks here programmatically anyway. - Brian Wickman On Feb. 11, 2014, 3:31 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17948/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2014, 3:31 p.m.) > > > Review request for Aurora, David Robinson and Brian Wickman. > > > Bugs: aurora-202 > https://issues.apache.org/jira/browse/aurora-202 > > > Repository: aurora > > > Description > ------- > > Implement help message generation for the noun/verb framework. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/__init__.py > 9eb5c52097f0e75567977ba2d4fe10932d227a4b > src/main/python/apache/aurora/client/cli/client.py > e416d3879cc5943ec5ab3931a8b1aedb85a379a9 > src/main/python/apache/aurora/client/cli/jobs.py > caff6d824d9f43cc9eb0c738ea6bb489321d4669 > src/main/python/apache/aurora/client/cli/options.py > 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 > src/main/python/apache/aurora/client/cli/quota.py > a7bcfbe0100fe8e400abda3710519e3e5029c477 > src/test/python/apache/aurora/client/cli/BUILD > c106b97a0902da5cd791b18117da3198bfb43b8c > src/test/python/apache/aurora/client/cli/test_help.py PRE-CREATION > > Diff: https://reviews.apache.org/r/17948/diff/ > > > Testing > ------- > > Added unit tests of new functions; verified that all client tests pass. > > > Thanks, > > Mark Chu-Carroll > >