> On March 3, 2014, 6:06 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/base/Query.java, line 387 > > <https://reviews.apache.org/r/18655/diff/1/?file=507500#file507500line387> > > > > To continue this conversation, I don't quite feel merging job > > (role/env/name) and jobKey extraction/building points would make much > > logical sense. > > > > Given the current filter implementation, the jobKeys from the set would > > be ORed between each other but ANDed with the job key derived from > > role/env/name fields. Unionizing the two would just send the wrong message > > as the job built out of role/env/name will not be treated the same way as > > the set of keys. > > > > Combining the two would make for mutually exclusive combinations. > > Example: byJobs(IJobKey jobKey, IJobKey... jobKeys) would have to shred the > > first key to role/env/name fields and send the rest to the Set<IJobKey> > > (see the test case below). > > > > Given the above, I can see some benefits in merging the two on the > > extraction side (i.e. from(), isJobKeyScoped()) but I feel that the > > construction side should remain separate (byJob, byJobKeys). Thoughts?
I'll let you make the call from here. The semantic probably isn't too important given that we want to get rid of the overlap in short order. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review35988 ----------------------------------------------------------- On March 1, 2014, 12:54 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18655/ > ----------------------------------------------------------- > > (Updated March 1, 2014, 12:54 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-235 > https://issues.apache.org/jira/browse/AURORA-235 > > > Repository: aurora > > > Description > ------- > > Added an optional JobKey set filter into the TaskQuery. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/base/JobKeys.java > 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95 > src/main/java/org/apache/aurora/scheduler/base/Query.java > d6f27fd6b8029401c918f942253beb59b6a71ddf > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > 421b33023e3b443d579685f434a4e09957b1c6e0 > src/main/thrift/org/apache/aurora/gen/api.thrift > f9fc6bcb7fdc2380043cf673a4002886192c20c1 > src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java > 0c1b144bf22f1bf400da04bd5826a04891dfada2 > src/test/resources/org/apache/aurora/gen/api.thrift.md5 > 08c4c2a4717a1c827f4cef6405d78e7db5046a00 > > Diff: https://reviews.apache.org/r/18655/diff/ > > > Testing > ------- > > /build-support/jenkins/build.sh > > > Thanks, > > Maxim Khutornenko > >
