----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19159/#review37008 -----------------------------------------------------------
src/main/python/apache/aurora/client/commands/core.py <https://reviews.apache.org/r/19159/#comment68255> This is deliberate: the "kill" command doesn't have a "force" option. So this ensures that there's more than a search-and-replace killall for kill: you need to deliberately use the killall command, and specify the force option. The require --shards is also in this change - see the change above in kill. - Mark Chu-Carroll On March 12, 2014, 6:11 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19159/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 6:11 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: aurora-260 > https://issues.apache.org/jira/browse/aurora-260 > > > Repository: aurora > > > Description > ------- > > Add killall. > > - the kill command now requires a shards parameter. > - the new killall command only works when run with "--force". > - killall generates a scary warning message, and pauses to give > the user a chance to abort. > > > Diffs > ----- > > src/main/python/apache/aurora/client/commands/core.py > ff0f1f8668c8c405fa3a41b70cae32004034e223 > src/test/python/apache/aurora/client/commands/test_kill.py > 7639dc98bfea0663461d15e3d46f1aedd13b124f > > Diff: https://reviews.apache.org/r/19159/diff/ > > > Testing > ------- > > Modified the existing kill command's test suite, adding new tests of the new > functionality. All pass. > > [sun-wukong incubator-aurora (killall)]$ ./pants > src/test/python/apache/aurora/client/commands:core > Build operating on targets: > OrderedSet([PythonTests(src/test/python/apache/aurora/client/commands/BUILD:core)]) > ============================= test session starts > ============================= > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 26 items > > src/test/python/apache/aurora/client/commands/test_cancel_update.py .. > src/test/python/apache/aurora/client/commands/test_create.py ...... > src/test/python/apache/aurora/client/commands/test_diff.py ... > src/test/python/apache/aurora/client/commands/test_kill.py ..... > src/test/python/apache/aurora/client/commands/test_listjobs.py .. > src/test/python/apache/aurora/client/commands/test_restart.py ... > src/test/python/apache/aurora/client/commands/test_status.py .. > src/test/python/apache/aurora/client/commands/test_update.py ... > > ========================= 26 passed in 11.34 seconds > ========================== > src.test.python.apache.aurora.client.commands.core > ..... SUCCESS > > > Thanks, > > Mark Chu-Carroll > >
