----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review37933 -----------------------------------------------------------
src/main/python/apache/aurora/client/cli/jobs.py <https://reviews.apache.org/r/19431/#comment69748> The "instance" syntax is mandatory for commands that can operate on instances. The parser is shared between all of them. For restart, run, and update, it make sense to be able to say "all shard". So you can say "all" instead of providing a numeric range. For kill, we don't want to allow users to specify "all"; we wnt them to use killall. src/main/python/apache/aurora/client/cli/jobs.py <https://reviews.apache.org/r/19431/#comment69749> Yes. Some of the wildcard stuff is still more up-in-the-air than I'd like; I just haven't had time to go through and make it uniform. The parser will still allow a wildcard. The wildcard won't actually be expanded to match anything, because that code doesn't run in kill. But there should be a proper, uniform error message in all commands that don't support wildcarding. src/main/python/apache/aurora/client/cli/jobs.py <https://reviews.apache.org/r/19431/#comment69750> See above. I can't remember who I've talked to about it - I know I've talked about i, but I don't remember who. Without instance syntax, if you run "aurora job update c/r/e/j" without "--instances", it automatically runs on all instances. With instance syntax, the parameter to update and restart is a five-tuple, one part of which is a shard specifier. We don't want to eliminate all-shard update, but this does add a degree of safety, in that you can't accidentally update all shards: you need to explicitly say that that's what you want to do. - Mark Chu-Carroll On March 19, 2014, 7:38 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19431/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 7:38 p.m.) > > > Review request for Aurora, Bill Farner and Brian Wickman. > > > Bugs: aurora-268 > https://issues.apache.org/jira/browse/aurora-268 > > > Repository: aurora > > > Description > ------- > > Add instance specifier syntax to commands that can specify instances for > clientv2. > > Also, while I was at it, I added the kill/killall distinction to clientv2. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/jobs.py > 2e62519a0531b2c910bc2c0227fd835baee644f1 > src/main/python/apache/aurora/client/cli/options.py > 0e0bd45f9506e5dc729a24cd68b04b49650605b6 > src/main/python/apache/aurora/client/cli/task.py > 8d4d38efbd126911f46bc3f8944e81bc9d149e32 > src/test/python/apache/aurora/client/cli/test_kill.py > 6040ed45eb1d2d8ed2b0a09718e13ad8dbb0e6aa > src/test/python/apache/aurora/client/cli/test_restart.py > aa23d5bfe81361243d82aadf9dc574608e28d953 > src/test/python/apache/aurora/client/cli/test_update.py > 51858b9e4ca02c2ae2151275fff9936460936bb4 > > Diff: https://reviews.apache.org/r/19431/diff/ > > > Testing > ------- > > [sun-wukong incubator-aurora (instance-syntax)]$ !./p > ./pants src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py .... > > =========================== 4 passed in 0.02 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_help.py ..... > > =========================== 5 passed in 0.48 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 27 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py .... > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py ..... > src/test/python/apache/aurora/client/cli/test_restart.py ... > src/test/python/apache/aurora/client/cli/test_status.py ....... > src/test/python/apache/aurora/client/cli/test_update.py ... > > ========================== 27 passed in 1.63 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_plugins.py .. > > =========================== 2 passed in 0.49 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 3 items > > src/test/python/apache/aurora/client/cli/test_quota.py ... > > =========================== 3 passed in 0.50 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_sla.py ..... > > =========================== 5 passed in 0.53 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_task_run.py .. > > =========================== 2 passed in 0.50 seconds > =========================== > src.test.python.apache.aurora.client.cli.bridge > ..... SUCCESS > src.test.python.apache.aurora.client.cli.help > ..... SUCCESS > src.test.python.apache.aurora.client.cli.job > ..... SUCCESS > src.test.python.apache.aurora.client.cli.plugins > ..... SUCCESS > src.test.python.apache.aurora.client.cli.quota > ..... SUCCESS > src.test.python.apache.aurora.client.cli.sla > ..... SUCCESS > src.test.python.apache.aurora.client.cli.task > ..... SUCCESS > [sun-wukong incubator-aurora (instance-syntax)]$ > [sun-wukong incubator-aurora (instance-syntax)]$ grep INSTANCES_OPTION > src/main/python/apache/aurora/client/cli/*.py > src/main/python/apache/aurora/client/cli/options.py:INSTANCES_OPTION = > CommandOption('--instances', type=parse_instances, dest='instances', > src/main/python/apache/aurora/client/cli/task.py: INSTANCES_OPTION, > [sun-wukong incubator-aurora (instance-syntax)]$ ./pants > src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py .... > > =========================== 4 passed in 0.02 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_help.py ..... > > =========================== 5 passed in 0.47 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 27 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py .... > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py ..... > src/test/python/apache/aurora/client/cli/test_restart.py ... > src/test/python/apache/aurora/client/cli/test_status.py ....... > src/test/python/apache/aurora/client/cli/test_update.py ... > > ========================== 27 passed in 1.65 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_plugins.py .. > > =========================== 2 passed in 0.51 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 3 items > > src/test/python/apache/aurora/client/cli/test_quota.py ... > > =========================== 3 passed in 0.49 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 5 items > > src/test/python/apache/aurora/client/cli/test_sla.py ..... > > =========================== 5 passed in 0.53 seconds > =========================== > ============================= test session starts > ============================== > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > collected 2 items > > src/test/python/apache/aurora/client/cli/test_task_run.py .. > > =========================== 2 passed in 0.53 seconds > =========================== > src.test.python.apache.aurora.client.cli.bridge > ..... SUCCESS > src.test.python.apache.aurora.client.cli.help > ..... SUCCESS > src.test.python.apache.aurora.client.cli.job > ..... SUCCESS > src.test.python.apache.aurora.client.cli.plugins > ..... SUCCESS > src.test.python.apache.aurora.client.cli.quota > ..... SUCCESS > src.test.python.apache.aurora.client.cli.sla > ..... SUCCESS > src.test.python.apache.aurora.client.cli.task > ..... SUCCESS > > > Thanks, > > Mark Chu-Carroll > >
