----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19313/#review38086 -----------------------------------------------------------
docs/README.md <https://reviews.apache.org/r/19313/#comment70051> Weasel wording: "typical services consist of up to hundreds". Either say "typical services consist of hundreds" or "services consist of up to hundreds". docs/README.md <https://reviews.apache.org/r/19313/#comment70052> shards *or* instances. docs/README.md <https://reviews.apache.org/r/19313/#comment70053> Not true. There are virtually no tasks that are single processes. Almost every task is a sequence of at least 2 commands: install binary, and run. docs/README.md <https://reviews.apache.org/r/19313/#comment70054> Get rid of trailing whitespace. docs/clientcommands.md <https://reviews.apache.org/r/19313/#comment70055> Every line in this ToC has trailing whitespace. docs/clientcommands.md <https://reviews.apache.org/r/19313/#comment70056> you've got a dash instead of an =. docs/clientcommands.md <https://reviews.apache.org/r/19313/#comment70057> "/"s. docs/clientcommands.md <https://reviews.apache.org/r/19313/#comment70058> Keep lines <100columns. docs/configurationreference.md <https://reviews.apache.org/r/19313/#comment70059> Again, tons of trailing whitespace here. docs/configurationreference.md <https://reviews.apache.org/r/19313/#comment70060> Here and elsewhere in the doc, reviewboard is complaining that you're using a smartquote instead of a ' character. This will cause trouble for some people reading on the command-line. docs/configurationreference.md <https://reviews.apache.org/r/19313/#comment70061> No need for weaselword "typically" here. docs/hooks.md <https://reviews.apache.org/r/19313/#comment70062> Tons of trailing whitespace everywhere, and smart quotes for apostrophes. - Mark Chu-Carroll On March 17, 2014, 3:01 p.m., Tom Galloway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19313/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 3:01 p.m.) > > > Review request for Aurora, Chris Lambert, Dave Lester, and Mark Chu-Carroll. > > > Repository: aurora > > > Description > ------- > > added killall command > > > Added killall command, changed kill command doc > > > Removed content about null-op {{#x}} > > > Minor edits > > > Minor edits > > > Minor edits > > > Minor edits > > > Minor edits > > > Minor edits > > > Minor edits > > > Minor edits > > > Minor Constraint/order() correction 2 > > > Minor Constraint/order() correction > > > Client command hooks doc > > > Resource isolation doc > > > Configuration tutorial > > > User guide doc > > > Configuration file reference > > > Tutorial doc > > > Client commands doc > > > User doc overview > > > Doc images > > > Adding initial image in images directory > > > Diffs > ----- > > docs/README.md PRE-CREATION > docs/clientcommands.md PRE-CREATION > docs/configurationreference.md PRE-CREATION > docs/configurationtutorial.md PRE-CREATION > docs/hooks.md PRE-CREATION > docs/images/CPUavailability.png PRE-CREATION > docs/images/HelloWorldJob.png PRE-CREATION > docs/images/RoleJobs.png PRE-CREATION > docs/images/ScheduledJobs.png PRE-CREATION > docs/images/TaskBreakdown.png PRE-CREATION > docs/images/aurora_hierarchy.png PRE-CREATION > docs/images/killedtask.png PRE-CREATION > docs/images/lifeofatask.png PRE-CREATION > docs/images/runningtask.png PRE-CREATION > docs/images/stderr.png PRE-CREATION > docs/images/stdout.png PRE-CREATION > docs/resourceisolation.md PRE-CREATION > docs/tutorial.md PRE-CREATION > docs/userguide.md PRE-CREATION > > Diff: https://reviews.apache.org/r/19313/diff/ > > > Testing > ------- > > > Thanks, > > Tom Galloway > >
