----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20986/#review42337 -----------------------------------------------------------
src/main/python/apache/aurora/client/api/sla.py <https://reviews.apache.org/r/20986/#comment76106> rather than make this required, maybe define DEFAULT_MIN_INSTANCE_COUNT=2 and do min_instance_count=DEFAULT_MIN_INSTANCE_COUNT in the initializer. this way it's not required everywhere. src/main/python/apache/aurora/client/api/sla.py <https://reviews.apache.org/r/20986/#comment76108> hosts should be passed in as hosts=hosts to differentiate it from positional args in general. this is mostly just style though. - Brian Wickman On May 1, 2014, 9:49 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20986/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 9:49 p.m.) > > > Review request for Aurora and Brian Wickman. > > > Bugs: AURORA-305 > https://issues.apache.org/jira/browse/AURORA-305 > > > Repository: aurora > > > Description > ------- > > Low instance count jobs prevent hosts from showing up in the safe domain > list. Adding an option to control jobs included into results. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/__init__.py > d8a23274bc9d0ba2d0ebc232652ff8c4c5da6eb1 > src/main/python/apache/aurora/client/api/sla.py > bb705caab4ef7749971613e23c8f6b0d3968ba23 > src/main/python/apache/aurora/client/commands/admin.py > 912851af1da0f6f706e55e28f6e949e1750b9897 > src/test/python/apache/aurora/client/api/test_sla.py > 359599af400d621e5652c2e56d01802a804abcc9 > src/test/python/apache/aurora/client/commands/test_admin_sla.py > aaf6c7f05caf8c809429a122e3d02e8ebb2fa54e > > Diff: https://reviews.apache.org/r/20986/diff/ > > > Testing > ------- > > ./pants src/test/python:all > > > Thanks, > > Maxim Khutornenko > >
