> On May 27, 2014, 12:36 p.m., Maxim Khutornenko wrote: > > src/main/thrift/org/apache/aurora/gen/api.thrift, line 471 > > <https://reviews.apache.org/r/21830/diff/2/?file=590911#file590911line471> > > > > Would it make sense to change it to list instead? I can imagine how the > > order may be helpful here in troubleshooting multi-message errors. > > Bill Farner wrote: > The use of set self-documents that you will not receive duplicate > ResponseDetail objects. Not sure i see the troubleshooting angle.
I agree with Maxim about this one. The order in which messages were added to the response could be a valuable piece of information about what order events occurred in. Even if there were duplicates, it seems like the fact that the scheduler inserted two copies of a given message could be very valuable when debugging. It does seem like it would be wrong, but it would be wrong in a way that provides a helpful clue about what the server is doing. - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43977 ----------------------------------------------------------- On May 27, 2014, 1:39 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21830/ > ----------------------------------------------------------- > > (Updated May 27, 2014, 1:39 p.m.) > > > Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim > Khutornenko. > > > Bugs: AURORA-461 > https://issues.apache.org/jira/browse/AURORA-461 > > > Repository: aurora > > > Description > ------- > > This also included a small amount of cleanup in the aop package, since we now > use a uniform response type. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 6f3ebd3191c766f28a6824d4c12c500a7aecf576 > src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java > 8eb52dd87a79d9c17426197a5460e2a49d988e13 > src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java > 1d69aa108795d41844454dc79e809d18ff6904bc > > src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java > 8299cf308cb8bd318ccd441e5f1b5607b2df881f > > src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java > a3e0c4233591857cb24a89a75c7ccfbdf28c44a3 > src/main/python/apache/aurora/client/api/__init__.py > 7c15d9dbd4fa9fa149cff867a31f0ce092beef95 > src/main/python/apache/aurora/client/api/command_runner.py > b2e28323a4cb13f456d2a44ebbb7e3a69c32ff0c > src/main/python/apache/aurora/client/api/instance_watcher.py > 15a7f74f10f1edf51cc6244b54e6ebd4a667cb88 > src/main/python/apache/aurora/client/api/quota_check.py > 3a73f2406c4bfa94bd75ea02490b7c6a946f379b > src/main/python/apache/aurora/client/api/restarter.py > 15258c4a6879c923b53d228af006b8cf6c6423a7 > src/main/python/apache/aurora/client/api/updater.py > f028498840ee4ed40790360ea6b6024ae623d60a > src/main/python/apache/aurora/client/base.py > 1f41ef05fafe5f5d73969d1453afd0dda0121927 > src/main/python/apache/aurora/client/cli/context.py > b1e8e407f27d6ae0512057211b147836f28eeac3 > src/main/python/apache/aurora/client/cli/jobs.py > 59e3a37e65b1c715e37e55f053d60670598e3a1e > src/main/python/apache/aurora/client/cli/task.py > d5c58db0375c0a59f3ee1f1b682813e34da44aa0 > src/main/python/apache/aurora/client/commands/admin.py > 4bf5735f1364ea1bed5387aabd08a845fa2390ee > src/main/python/apache/aurora/client/commands/core.py > 4eb4e465dcdea859984835dfa9878b1d92ccb5ab > src/main/python/apache/aurora/client/hooks/hooked_api.py > 7c3b866dda0e5b7bd51d02fa43d92b86a74206c1 > src/main/thrift/org/apache/aurora/gen/api.thrift > c6e1fcbd3c0a08c8ff41dc029f9efc88939f1418 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 75bb01b25f47cb46f229dd08a4c0881191aa5fe4 > src/test/python/apache/aurora/client/api/test_disambiguator.py > 08d671b0591069ed0db87fb7ee64c8d81e5b0e8c > src/test/python/apache/aurora/client/api/test_instance_watcher.py > 89f1d90a93f1a339b7d8d27a86421726391d02f4 > src/test/python/apache/aurora/client/api/test_job_monitor.py > 7fe1a00b229f17300731e5b7eb6fb976f9710661 > src/test/python/apache/aurora/client/api/test_quota_check.py > 9439d99361ab1800aec0c85b158ec1316172212c > src/test/python/apache/aurora/client/api/test_restarter.py > 0e00f448c45c9f575f126dbc0f1227893d7a79cf > src/test/python/apache/aurora/client/api/test_sla.py > f9490b4dcc2ec051d68720e79afebfde982a79c5 > src/test/python/apache/aurora/client/api/test_updater.py > 6be419eccc7e20c7728d6e52955db3fd289f6a29 > src/test/python/apache/aurora/client/cli/util.py > 6533fae95b01c4ab3daf791fddf5417167bbbecb > src/test/python/apache/aurora/client/commands/test_kill.py > 00c4ceffd0ff562088a2215cc97d67a434e2394d > src/test/python/apache/aurora/client/commands/util.py > f5346841f760f30143317ac49f1d0e54144b0419 > > Diff: https://reviews.apache.org/r/21830/diff/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > > Thanks, > > Bill Farner > >
