> On May 23, 2014, 6:53 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java, line 45 > > <https://reviews.apache.org/r/21849/diff/1/?file=589370#file589370line45> > > > > Mixed final and non-final classes in this file - converge on one? > > Bill Farner wrote: > Dropped the only final class.
Just realized now that a check wanted TaskStateChange to be final since it has a private constructor. Marked that guy final again and documented the reason. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21849/#review43854 ----------------------------------------------------------- On May 27, 2014, 6:08 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21849/ > ----------------------------------------------------------- > > (Updated May 27, 2014, 6:08 p.m.) > > > Review request for Aurora, David McLaughlin and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > By default, the PMD plugin includes the 'basic' ruleSet. Rulesets are > collections of individual rules, the downside being that they're all or none. > To disable one rule within a ruleset, for example, you need to copy the > ruleset definition XML and edit it. I've done that here with two rulesets, > by minimally editing them (added apache header, and commented out disabled > rules). > > If you're interested, you can see more info at the official ruleset listing > [1]. > > Most of the larger edits made are to adhere to the ConfusingTernary rule [2]. > > I also moved the isCron() function as it tripped a rule, and after a bout of > deja vu i realized it recently suffered a complete copy-paste. It is now > de-cloned and lives in SanitizedConfiguration. > > [1] http://pmd.sourceforge.net/pmd-5.1.1/rules/index.html > [2] > http://pmd.sourceforge.net/pmd-5.1.1/rules/java/design.html#ConfusingTernary > > > Diffs > ----- > > build.gradle 0dbaa61bc2b0558ecab55b831b95ab6e704767e6 > config/pmd/design.xml PRE-CREATION > config/pmd/logging-java.xml PRE-CREATION > src/main/java/org/apache/aurora/auth/SessionValidator.java > 6b0f42335a6cb74f31403c13da33037f1f699aeb > src/main/java/org/apache/aurora/scheduler/Driver.java > 15e90d40e05bea2023e4904ed958a36d0f17d2a8 > src/main/java/org/apache/aurora/scheduler/DriverFactory.java > 549ef114b813718c7da7218cccb8aca600ce9dae > src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java > f05b05af0200d0681fa3b5147bb73e8f83264ff8 > src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java > 06a12a18f6d3e51dafdfaeb2d07511f16a67e9aa > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java > 5c0f09f312a8d5328f3c57dbf96c2201e0a33aba > src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java > e2492de432a13282d1bad3596026d81b08599cd4 > src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java > 17ddfc9077cbde36d73fe5a33a6d3fda0f902551 > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java > a56f03736d65f992542f89f6897723bb39d53a1f > src/main/java/org/apache/aurora/scheduler/base/CommandUtil.java > da06f123ffd2207fa14e9682ec43957db5ea90f7 > src/main/java/org/apache/aurora/scheduler/base/Query.java > a5350c8b2e0494dcaf0577c77ac919ea7bb3dd79 > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > f86a5b742b760f723b3873e949a3c398e0a98195 > src/main/java/org/apache/aurora/scheduler/configuration/Resources.java > 5a38479bfbe41d06dc5224b77cbaaee0814585af > > src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java > 7fc493069455291deee15c75774a3d7cd4f8aa92 > src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java > cc0813774736168f9a8b4c125c1efa94978d7340 > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java > 8f72a2d46ed8c9cb82ff1d376f9348b7d5e56cb7 > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java > 0094c88694d3bca5de08e38f6fbf99877885b352 > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java > 06a5f8f5ab34861d71b167e95fdfa819232d8a1d > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java > d8daa6865db9fca9fda8d27a5b076484e2a3ba87 > src/main/java/org/apache/aurora/scheduler/http/JerseyTemplateServlet.java > c955640e8ad7a797ee322826b392816867e2395d > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java > 9cb85bb41410ee30530a05b19cd4c86adbf8585c > src/main/java/org/apache/aurora/scheduler/http/Quotas.java > b516470e5f56423671d6b9f98d4a185cb55eeccd > src/main/java/org/apache/aurora/scheduler/http/Slaves.java > 56a8ce18bcbfc3329ffa2792311573cb42fc0483 > src/main/java/org/apache/aurora/scheduler/http/StructDump.java > 7bf2fba46bc0ac5fe308bf3ca9f54fc0719631a3 > > src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java > a9d5f8f9ee7a5204afe6b5b36b99badadf21ba31 > src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java > 396cecf2b357169b4124ef6547fcbaf02adfbcb6 > src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java > 3390038d6e2e6934e5f3c18a887e5f5f399390e5 > src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java > 46446a9dbaec3a98c6df376372d5c5fc1981b9c2 > src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java > 616bdc4295e90660f5d47c5a2d6d95a50992ec47 > src/main/java/org/apache/aurora/scheduler/storage/JobStore.java > dcd0ab0a1f99f4a6c1bf08ab506ff489fe1bb1e5 > src/main/java/org/apache/aurora/scheduler/storage/LockStore.java > 4e2371c7fb210c79ceef91d559cd55553f88cea5 > src/main/java/org/apache/aurora/scheduler/storage/QuotaStore.java > 0270e584f361dfc29a3c58586e56f7337bcf96aa > src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java > c16f70d31a80cd3d6dd1f479629e063f21aada1c > src/main/java/org/apache/aurora/scheduler/storage/SchedulerStore.java > f6a992d10009bba6f071977d6364878941b91b8b > src/main/java/org/apache/aurora/scheduler/storage/Storage.java > 768a8215b46433c003dac5471b94542e4a22d0b0 > src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java > d507666b2bf6b0eedc74ae810c2be79b8bc25f5f > src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java > 40503b441cd450576684a7a9d300710c50138484 > src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java > 17b79c3e8855a3df74bd4644c7afb51b3529207f > src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java > e3c09e0aea27ba864fd242bb4cdeecdd337fb1c4 > src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java > c31fe2de0589df65212816c2af79f98a864cd2c4 > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java > 899c61a2eaf2ddca51cb637dd4ee3784b8dd24fe > > src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java > 87a442b0b6213f47dbf7cab9b3abef2f72907122 > > src/main/java/org/apache/aurora/scheduler/storage/mem/MemAttributeStore.java > 429691c3cd7c9583d7d55a946c74908acff21288 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobStore.java > 962861de19b5fd3cea8600a24926876481a8ae10 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 6f3ebd3191c766f28a6824d4c12c500a7aecf576 > > src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java > 8eb52dd87a79d9c17426197a5460e2a49d988e13 > > Diff: https://reviews.apache.org/r/21849/diff/ > > > Testing > ------- > > ./gradlew build > > > Thanks, > > Bill Farner > >
