----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/#review48418 -----------------------------------------------------------
src/main/python/apache/aurora/admin/host_maintenance.py <https://reviews.apache.org/r/23244/#comment84984> Oh, I see. So why not just do "if host_groups and len(host_groups) > 1"? - Mark Chu-Carroll On July 22, 2014, 12:41 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23244/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 12:41 p.m.) > > > Review request for Aurora, Joe Smith and Mark Chu-Carroll. > > > Bugs: AURORA-571 > https://issues.apache.org/jira/browse/AURORA-571 > > > Repository: aurora > > > Description > ------- > > Fixing return value in _check_sla. Also, adding logging in drainHosts RPC to > help troubleshooting occasional LOST tasks when draining. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java > bf48db97cf882105c0b2e6b70f9a4612ce60dbe8 > src/main/python/apache/aurora/admin/host_maintenance.py > b5b1375b1bbaed833acf2d17ec432b3d99145fab > src/test/python/apache/aurora/client/commands/test_maintenance.py > c4677fc2cf4cfa792823cd0660c13371ec28301f > > Diff: https://reviews.apache.org/r/23244/diff/ > > > Testing > ------- > > gradle -Pq build > ./pants src/test/python:all > > > Thanks, > > Maxim Khutornenko > >