----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24116/#review49271 -----------------------------------------------------------
src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86203> Total nit, but shouldn't min come before max? src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86204> FWIW, I think bill's states are clearer. src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86205> Definitely support the idea of the more general queries. If we're going to the trouble of supporting an API like this, we should make the extra effort to make it flexible. - Mark Chu-Carroll On July 31, 2014, 2:37 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24116/ > ----------------------------------------------------------- > > (Updated July 31, 2014, 2:37 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-611 > https://issues.apache.org/jira/browse/AURORA-611 > > > Repository: aurora > > > Description > ------- > > First stab at update APIs. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 12de5a3e9e3aae217b30c385e2d7ec7b43863ae2 > src/main/thrift/org/apache/aurora/gen/api.thrift > 54b8985971719247a5d42d8676075a51045bbb92 > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java > 2ea4a9ba0a1ea81fea5c4f5203457aa79ae67c10 > > Diff: https://reviews.apache.org/r/24116/diff/ > > > Testing > ------- > > gradle build > > > Thanks, > > Maxim Khutornenko > >
