> On Aug. 28, 2014, 8:48 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 150 > > <https://reviews.apache.org/r/24995/diff/1/?file=667710#file667710line150> > > > > What's going on here? A comment explaining this formula would be > > helpful.
Added some comments around to help. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/#review51824 ----------------------------------------------------------- On Aug. 22, 2014, 8:55 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24995/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2014, 8:55 p.m.) > > > Review request for Aurora, David McLaughlin and Kevin Sweeney. > > > Bugs: AURORA-649 > https://issues.apache.org/jira/browse/AURORA-649 > > > Repository: aurora > > > Description > ------- > > First step towards checking quota in startJobUpdate RPC. The final thrift > wiring is to follow. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java > 7a1a09b94cfe6d4b58ef4e6ab958b71c4be1e9bd > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java > 24145f52a17ec9b7458aa5578a5b99ef5b1cddab > src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java > 3dcb1c3e3d0138634b3d077c845ecc0d61d7fc0f > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > f679f38f0fcff8abf2442cfcd885cd202ac55528 > src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java > a0ef57ec8af2fd6993eda338da14d1f4346ed3a4 > > src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java > fa611a913bad40a8c0515c578b394c460340e574 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 997ade0be58723d1d91725061bb128ccf45e25b4 > > Diff: https://reviews.apache.org/r/24995/diff/ > > > Testing > ------- > > gradle -Pq build > > > Thanks, > > Maxim Khutornenko > >
