> On Sept. 25, 2014, 4:29 p.m., Kevin Sweeney wrote: > > src/test/python/apache/aurora/executor/common/test_announcer.py, line 264 > > <https://reviews.apache.org/r/25974/diff/2/?file=705691#file705691line264> > > > > where is this magic number coming from? extract a constant and import > > that here?
This is the default initial health check + (max failures * health check). I'm unsure on the best way to fix this without duplicating the code it is trying to test. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54623 ----------------------------------------------------------- On Sept. 25, 2014, 2:39 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25974/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 2:39 p.m.) > > > Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. > > > Bugs: AURORA-728 > https://issues.apache.org/jira/browse/AURORA-728 > > > Repository: aurora > > > Description > ------- > > Prevent initial ZK timeouts from killing the executor. In addition, prevent > uncaught exceptions from killing the executor. > > > Diffs > ----- > > src/main/python/apache/aurora/executor/aurora_executor.py > 79a24855b2a68271b7478395dfdadab8755c3af2 > src/main/python/apache/aurora/executor/common/announcer.py > c466da8d48bbc2aa227c2db157cab84665ad6602 > src/test/python/apache/aurora/executor/common/test_announcer.py > 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 > > Diff: https://reviews.apache.org/r/25974/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/executor:executor-small > > > Thanks, > > Zameer Manji > >
