> On Sept. 29, 2014, 4:31 p.m., Brian Wickman wrote: > > david -- could you publish a remote branch somewhere that i can use to > > merge this to master? the reviewboard diff does not contain the .ico and > > ./rbt patch does not support binary diffs.
https://github.com/zxvdr/incubator-aurora/tree/favicon - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/#review54819 ----------------------------------------------------------- On July 31, 2014, 12:13 a.m., David Robinson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23330/ > ----------------------------------------------------------- > > (Updated July 31, 2014, 12:13 a.m.) > > > Review request for Aurora, David McLaughlin and Brian Wickman. > > > Bugs: AURORA-577 > https://issues.apache.org/jira/browse/AURORA-577 > > > Repository: aurora > > > Description > ------- > > replace 143 kB favicon with 318 byte version. > > $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico > src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows > icon resource - 2 icons, 229x201 > $ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico > -rw-rw-r--. 1 drobinson drobinson 143K Jul 7 17:42 > src/main/python/apache/thermos/observer/http/assets/favicon.ico > > $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico > src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows > icon resource - 1 icon, 16x16, 16 colors > $ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico > -rw-rw-r--. 1 drobinson drobinson 318 Jul 7 17:42 > src/main/python/apache/thermos/observer/http/assets/favicon.ico > > > Diffs > ----- > > src/main/python/apache/thermos/observer/http/assets/favicon.ico > 048d2e4b17a7a2d69dd1320efdebe14cb6095376 > src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl > 511d7c06206ae5fd8a4206683f09348e1276b8c4 > src/main/python/apache/thermos/observer/http/templates/index.tpl > 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 > src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl > b182a4b331fbe8b9dd437194d195d220184a2f7c > > Diff: https://reviews.apache.org/r/23330/diff/ > > > Testing > ------- > > > Thanks, > > David Robinson > >