----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26298/ -----------------------------------------------------------
Review request for Aurora, Mark Chu-Carroll and Maxim Khutornenko. Repository: aurora Description ------- A few times when making changes, i've found myself confused at a stalled test and spiked CPU, only to find that my test should have failed, but an exception is trapped in this retry loop. The key change here is that unknown exceptions will break the loop. Making this change pointed out what should have been a test failure in `test_transient_error`, where an exception caused by an unexpected call to `getVersion` was swallowed. I also changed the test to avoid sleeping, which was eating a fixed 10 seconds of unit test time. Diffs ----- src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442 Diff: https://reviews.apache.org/r/26298/diff/ Testing ------- ./pants src/test/python:all -vxs Thanks, Bill Farner
