----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/#review55493 -----------------------------------------------------------
src/main/python/apache/aurora/client/cli/__init__.py <https://reviews.apache.org/r/26328/#comment95880> This is a filename, not a print statement. The only reason that I'm using a time there is to ensure that it's unique. Creating filenames in the users workspace with spaces in it causes lots of unpleasantness for the user. It's just obnoxious to do that. - Mark Chu-Carroll On Oct. 3, 2014, 4:47 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26328/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2014, 4:47 p.m.) > > > Review request for Aurora, David McLaughlin and Zameer Manji. > > > Bugs: aurora-779 > https://issues.apache.org/jira/browse/aurora-779 > > > Repository: aurora > > > Description > ------- > > Improve handling of unknown errors in the aurora client. > > Instead of dumping the stack on the user's terminal, or > absorbing the error and generating a brief error > message, the client now writes detailed information about > the error is written into an error log file, and the > user is given a clean error message referring them to that > file for details. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/__init__.py > e0c3050151bca1128ed7e476ec5133407a20f6c2 > src/main/python/apache/aurora/client/cli/context.py > f639af7de93a069b278dc494b6f92a2f6b10de9c > src/main/python/apache/aurora/client/cli/options.py > 9a81a1d7d04c6648e94ff117429278317a9dbed8 > src/main/python/apache/aurora/client/cli/standalone_client.py > fd2232bc8b7e5caf487291f657a50184391a8c69 > src/main/python/apache/aurora/client/cli/update.py > b4dd792dc12f19424c620f4d91748113e272f0c9 > src/test/python/apache/aurora/client/cli/test_api_from_cli.py > 78f21d2f20cf71fa2dfe0614885d44d2948decd2 > src/test/python/apache/aurora/client/cli/test_create.py > 6e55188bdfc576506848605debb391288e696fe3 > src/test/python/apache/aurora/client/cli/test_supdate.py > 2782fee2867c6ef79349240299de082f07f7967a > src/test/python/apache/aurora/client/cli/util.py > e1ee884c06f3bc22bcd9e908ff61af9459a0b535 > > Diff: https://reviews.apache.org/r/26328/diff/ > > > Testing > ------- > > New unit test. > > > Thanks, > > Mark Chu-Carroll > >