> On Oct. 6, 2014, 10:55 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/executor/common/health_checker.py, lines > > 157-158 > > <https://reviews.apache.org/r/26383/diff/1/?file=714260#file714260line157> > > > > I know you didn't originate this pattern, but it seems odd for these > > defaults to be repeated on both the HealthChecker and the > > ThreadedHealthChecker. Perhaps they should be constants, or maybe > > ThreadedHealthChecker shouldn't have defaults at all?
I actually did originate this pattern. The reason why ThreadedHealthChecker has defaults is because some tests don't care about all the parameters to ThreadedHealthChecker. For example, if my test doesn't care about the interval_secs, the defaults allow me to ignore that parameter altogether, and focus on the parameters that I actually care about. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/#review55590 ----------------------------------------------------------- On Oct. 6, 2014, 9:24 p.m., David Pan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26383/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 9:24 p.m.) > > > Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > The health check disabler allows health checks for a job to be snoozed > temporarily by touching a snooze file in the job's sandbox. The path of the > snooze file and the snooze duration can be set in the HealthCheckConfig. The > appropriate unit tests were modified/added. > > The corresponding JIRA ticket is the following: > https://issues.apache.org/jira/browse/AURORA-795 > > > Diffs > ----- > > docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec > docs/configuration-tutorial.md 67998e9dab6ac429d96d7c0d2df959336b767f32 > src/main/python/apache/aurora/config/schema/base.py > f12634f103c3eb20e43f37c25d9b0fc3e3d228ec > src/main/python/apache/aurora/executor/common/health_checker.py > 4980411c847d12655cbb363404707ebd9f0bd163 > src/test/python/apache/aurora/executor/common/BUILD > c7f7a003c865d479ba6e3cd7b5349322f884f653 > src/test/python/apache/aurora/executor/common/test_health_checker.py > aa36415fa891fc523a3a376ffeca5d3cd5ceabec > > Diff: https://reviews.apache.org/r/26383/diff/ > > > Testing > ------- > > On vagrant in ~/aurora, I ran > ./pants src/test/python/apache/aurora/executor:: > > > Thanks, > > David Pan > >
