----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27145/#review58301 -----------------------------------------------------------
Ship it! build-support/jenkins/review_feedback.py <https://reviews.apache.org/r/27145/#comment99252> replace with ternary? build-support/jenkins/review_feedback.py <https://reviews.apache.org/r/27145/#comment99253> Is there a legitimate case to allow non 200 response code here? build-support/jenkins/review_feedback.py <https://reviews.apache.org/r/27145/#comment99254> Combine with the above print? - Maxim Khutornenko On Oct. 24, 2014, 5:32 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27145/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 5:32 p.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Bugs: AURORA-883 > https://issues.apache.org/jira/browse/AURORA-883 > > > Repository: aurora > > > Description > ------- > > I also removed `--stacktrace` from the gradle command. This makes for better > tail output. I originally added `--stacktrace` to help debug build flakiness > we were having due to jenkins machine configuration (but haven't had in a > very long time): https://reviews.apache.org/r/23776/ > > > Diffs > ----- > > build-support/jenkins/build.sh 50ea950206b572f708feb0ebc1c3d04db6eaebd7 > build-support/jenkins/review_feedback.py PRE-CREATION > > Diff: https://reviews.apache.org/r/27145/diff/ > > > Testing > ------- > > I've run this a handful of times on my workstation, it seems to be doing its > job. > > > Thanks, > > Bill Farner > >
