----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27852/#review60888 -----------------------------------------------------------
src/main/python/apache/aurora/client/cli/task.py <https://reviews.apache.org/r/27852/#comment102294> Should we just make this the default behavior? There's at least 31 locations that do this, seems like a catch-all would be useful. If we do this, i'd recommend you remove all `return EXIT_OK` lines, so only proceed if you're okay with that. Looks like the relevant changes would be in: src/main/python/apache/aurora/client/cli/standalone_client.py src/main/python/apache/aurora/client/cli/client.py - Bill Farner On Nov. 11, 2014, 2:50 a.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27852/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 2:50 a.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-923 > https://issues.apache.org/jira/browse/AURORA-923 > > > Repository: aurora > > > Description > ------- > > Ensure run verb returns an exit code. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/task.py > 91175facdc8ccccc9fd59ab66781f86ee8b5940a > src/test/python/apache/aurora/client/cli/BUILD > e1f9ebf96774b8f5c75de8570c6ba87d953ab649 > src/test/python/apache/aurora/client/cli/test_task_run.py > 8d9ef0543c1ab514d6f039ba63a1d417a4a90a1b > > Diff: https://reviews.apache.org/r/27852/diff/ > > > Testing > ------- > > ./pants build src/test/python/apache/aurora/client/cli:: > > > Thanks, > > Zameer Manji > >