> On Nov. 14, 2014, 10:46 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 64 > > <https://reviews.apache.org/r/27705/diff/3/?file=764035#file764035line64> > > > > Please define static and dynamic vetos in a comment here.
Thanks for reminding. Meant to do that but it slipped. Done. > On Nov. 14, 2014, 10:46 p.m., Zameer Manji wrote: > > src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java, line 55 > > <https://reviews.apache.org/r/27705/diff/3/?file=764044#file764044line55> > > > > I think this will fail checkStyle. Damn intellij. Tweaked a few settings in CodeStyle -> Imports to hopefully never see it again. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review61525 ----------------------------------------------------------- On Nov. 14, 2014, 10:16 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27705/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 10:16 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-914 > https://issues.apache.org/jira/browse/AURORA-914 > > > Repository: aurora > > > Description > ------- > > Adding @Timed to trace scheduling latencies and Veto counters per type. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/TaskVars.java > cf8f7584afee758c527798914181049051aef0d8 > src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java > d2682cd910d248c897e691bcb4c8a3a6f1aec2d2 > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java > e2ba8b8fe978a58d1edcd01963ea020e54529353 > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java > 4821a7890b77ccb04c10bee6d8b4b9e7216940cc > src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java > 3839083f27ca5d4b93406152559b58b04e912a10 > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java > c1c5f26723f1eac3000e09e061b4582f922fded6 > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java > cc6b53b3265253f76c1e954c0108aa5936f5cc36 > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java > 87203690f09456ac1ca5e9da2b82826d60cbd723 > src/main/java/org/apache/aurora/scheduler/stats/CachedCounters.java > aaedb3b5ec2cb27550449435efa8f335c6a9baad > src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java > 12ea4c67350c2992f59bacd21a99d1413b60b757 > > src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java > 94f0a179b786649775899f855f7c1a0caab7290f > > src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java > e113eba1f304279b5ee3d70db1d1ea558efd63ac > src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java > b60b004adbd6753ec6fef125fd70286be5071c56 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c > > Diff: https://reviews.apache.org/r/27705/diff/ > > > Testing > ------- > > ./gradlew -Pq build > Verified new stats in vagrant. > > > Thanks, > > Maxim Khutornenko > >