----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28674/#review63733 -----------------------------------------------------------
src/main/python/apache/aurora/client/base.py <https://reviews.apache.org/r/28674/#comment106024> This uses a different quoting style than the rest of the file. src/main/python/apache/aurora/client/base.py <https://reviews.apache.org/r/28674/#comment106025> This will str() on a ResponseDetail object including the struct details that we don't need: ``` $ ./pants py src/main/python/apache/aurora/client:base >>> from gen.apache.aurora.api.ttypes import Response, ResponseDetail, ResponseCode >>> resp = Response(responseCode=ResponseCode.OK, details=[ResponseDetail(message='Quota check successful.')]) >>> ', '.join(map(str, resp.details or [])) "ResponseDetail(message='Quota check successful.')" ``` src/test/python/apache/aurora/client/api/test_job_monitor.py <https://reviews.apache.org/r/28674/#comment106028> Use kvarg 'message=' for consistency? src/test/python/apache/aurora/client/api/test_quota_check.py <https://reviews.apache.org/r/28674/#comment106029> same here src/test/python/apache/aurora/client/api/test_task_util.py <https://reviews.apache.org/r/28674/#comment106032> same here - Maxim Khutornenko On Dec. 3, 2014, 8:34 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28674/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 8:34 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Zameer Manji. > > > Bugs: AURORA-466 > https://issues.apache.org/jira/browse/AURORA-466 > > > Repository: aurora > > > Description > ------- > > Remove Response.message field. > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > 6b63f04a7113527e26d7f38e877b0ebd07822108 > src/main/java/org/apache/aurora/scheduler/thrift/Util.java > d879db4157c7a2c782e3213974067d86b6184f04 > src/main/python/apache/aurora/client/api/BUILD > 8b0da6725362c6d9a3af6524a76a855a9bcbfd40 > src/main/python/apache/aurora/client/api/__init__.py > d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59 > src/main/python/apache/aurora/client/api/command_runner.py > 14a316b6cda671764f2b2ac1ba5bbfef15eb1ab5 > src/main/python/apache/aurora/client/api/quota_check.py > 5877cba5dd06b2caa75ed0cab9786a80c2ae71b6 > src/main/python/apache/aurora/client/api/restarter.py > 43599e7ef7d17441f89f4a3a08b39b86d7d6fb5b > src/main/python/apache/aurora/client/api/updater.py > 2092ff31141b6ccfedf0af673fe8dc2a74a7828e > src/main/python/apache/aurora/client/base.py > 2c7d8160b23dbca0979cecf3bb44b904bf0d8de6 > src/main/python/apache/aurora/client/cli/context.py > 96c386e83db7b7c16419ca05b9155dd527bfb834 > src/main/python/apache/aurora/client/cli/task.py > 8a139db02ba6baf0dc558ccdba76d194fb0ebe88 > src/main/python/apache/aurora/client/commands/admin.py > cb5ae88e3f39b7d7fbb80593be664809fbaa8958 > src/main/python/apache/aurora/client/commands/core.py > ee227165d6f6b7c2a5c51d9e70b25b8cd0179381 > src/main/python/apache/aurora/client/hooks/hooked_api.py > 91efe5248144049d6a13b1ec81ffe08522df1ee9 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > d687f572b467a76e79d55ea1d7eb0abf7ec61bbd > src/test/python/apache/aurora/client/api/test_api.py > 1f4e9fe9111ac88726d7c45b699b3b91438448b6 > src/test/python/apache/aurora/client/api/test_disambiguator.py > e9523ac67a67f83f55a7d79f38a5c13a9a90694c > src/test/python/apache/aurora/client/api/test_instance_watcher.py > abbbdbe953e3a81b64eb77ab096cef22c6ffc4c6 > src/test/python/apache/aurora/client/api/test_job_monitor.py > 27d8025bc80cff22c2f025302d1fe0519d8632e9 > src/test/python/apache/aurora/client/api/test_quota_check.py > cb443c227589d69559c92444232eb6ba7d9259eb > src/test/python/apache/aurora/client/api/test_restarter.py > eb0af3bc588c088aa2aca8eb561cbd90d28209e1 > src/test/python/apache/aurora/client/api/test_sla.py > 50a6c47f00c77265328d6eacc835884e158b9e20 > src/test/python/apache/aurora/client/api/test_task_util.py > 3e772b949b0ec8b9cece62fc1ed46059a8310195 > src/test/python/apache/aurora/client/api/test_updater.py > a32fc529cb1b23ab926a9180debb68bb826f66a8 > src/test/python/apache/aurora/client/cli/util.py > 0ec74e675aaabc7ac0cb28e02f5b8534570b7a49 > src/test/python/apache/aurora/client/commands/test_admin.py > f9261affcc7d2f5391712fa0d0eb84e89a13bd70 > src/test/python/apache/aurora/client/commands/test_kill.py > 4ac742f4c7f3528cee0cdc25b9624ffde8384b11 > src/test/python/apache/aurora/client/commands/util.py > c06de50e81be57cbf0480b1566f0efcec07f8a9d > src/test/python/apache/aurora/client/test_base.py > 785784b3cb8e670111bb367363acc45772a8ea3e > > Diff: https://reviews.apache.org/r/28674/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
