----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28731/#review63947 -----------------------------------------------------------
This patch does not apply cleanly on master (fd37f0d), do you need to rebase? I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 5, 2014, 1:27 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28731/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 1:27 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Added baseline benchmarks for a few static veto cases. > > This is branched off of https://reviews.apache.org/r/28710 > > > Diffs > ----- > > build.gradle fb729c5096108c535229e266fa9649f997e6da37 > src/jmh/java/org/apache/aurora/benchmark/Offers.java PRE-CREATION > src/jmh/java/org/apache/aurora/benchmark/SchedulerBenchmark.java > PRE-CREATION > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > PRE-CREATION > src/jmh/java/org/apache/aurora/benchmark/Tasks.java PRE-CREATION > src/jmh/java/org/apache/aurora/benchmark/fakes/FakeDriver.java PRE-CREATION > src/jmh/java/org/apache/aurora/benchmark/fakes/FakeEventSink.java > PRE-CREATION > > src/jmh/java/org/apache/aurora/benchmark/fakes/FakeRescheduleCalculator.java > PRE-CREATION > src/jmh/java/org/apache/aurora/benchmark/fakes/FakeStatsProvider.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java > ead9d28100673440168a32d114ecaa15874978a6 > > Diff: https://reviews.apache.org/r/28731/diff/ > > > Testing > ------- > > Sample run on a local box: > ``` > # VM invoker: > /Library/Java/JavaVirtualMachines/jdk1.7.0_25.jdk/Contents/Home/jre/bin/java > # VM options: -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en > -Duser.variant > # Warmup: 10 iterations, 1 s each > # Measurement: 100 iterations, 1 s each > # Timeout: 10 min per iteration > # Threads: 1 thread, will synchronize iterations > # Benchmark mode: Average time, time/op > # Benchmark: > org.apache.aurora.benchmark.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example > > # Run progress: 0.00% complete, ETA 00:03:40 > # Fork: 1 of 1 > # Warmup Iteration 1: 104725900.000 ns/op > # Warmup Iteration 2: 20439888.889 ns/op > # Warmup Iteration 3: 13612185.185 ns/op > # Warmup Iteration 4: 5856248.677 ns/op > # Warmup Iteration 5: 5148014.019 ns/op > # Warmup Iteration 6: 4972004.505 ns/op > # Warmup Iteration 7: 4595562.500 ns/op > # Warmup Iteration 8: 4639226.891 ns/op > # Warmup Iteration 9: 4639521.008 ns/op > # Warmup Iteration 10: 4660248.945 ns/op > Iteration 1: 4718478.632 ns/op > Iteration 2: 4800686.957 ns/op > Iteration 3: 4438253.012 ns/op > Iteration 4: 4935376.682 ns/op > Iteration 5: 5236895.735 ns/op > Iteration 6: 6439345.029 ns/op > Iteration 7: 4792708.696 ns/op > Iteration 8: 4579008.299 ns/op > Iteration 9: 4681224.576 ns/op > Iteration 10: 4651143.460 ns/op > Iteration 11: 4394079.681 ns/op > Iteration 12: 4390573.705 ns/op > Iteration 13: 4363304.348 ns/op > Iteration 14: 4419488.000 ns/op > Iteration 15: 4869718.062 ns/op > Iteration 16: 4600612.500 ns/op > Iteration 17: 4475906.883 ns/op > Iteration 18: 4710388.889 ns/op > Iteration 19: 6137000.000 ns/op > Iteration 20: 4467425.101 ns/op > Iteration 21: 4348877.953 ns/op > Iteration 22: 4666907.173 ns/op > Iteration 23: 4431325.301 ns/op > Iteration 24: 4463186.235 ns/op > Iteration 25: 4580074.689 ns/op > Iteration 26: 4467805.668 ns/op > Iteration 27: 4886960.177 ns/op > Iteration 28: 4858515.419 ns/op > Iteration 29: 4734025.751 ns/op > Iteration 30: 4718081.197 ns/op > Iteration 31: 4711688.034 ns/op > Iteration 32: 4462392.713 ns/op > Iteration 33: 4683597.458 ns/op > Iteration 34: 4755176.724 ns/op > Iteration 35: 4530278.689 ns/op > Iteration 36: 4392119.048 ns/op > Iteration 37: 4659722.689 ns/op > Iteration 38: 4805869.565 ns/op > Iteration 39: 4398573.705 ns/op > Iteration 40: 4572547.718 ns/op > Iteration 41: 4643478.992 ns/op > Iteration 42: 4545699.588 ns/op > Iteration 43: 4670266.949 ns/op > Iteration 44: 4506677.551 ns/op > Iteration 45: 4574149.378 ns/op > Iteration 46: 4743154.506 ns/op > Iteration 47: 4777606.061 ns/op > Iteration 48: 4481987.805 ns/op > Iteration 49: 4840921.053 ns/op > Iteration 50: 4637231.092 ns/op > Iteration 51: 4515286.885 ns/op > Iteration 52: 4372884.921 ns/op > Iteration 53: 4385003.968 ns/op > Iteration 54: 4619648.536 ns/op > Iteration 55: 4557822.314 ns/op > Iteration 56: 4594362.500 ns/op > Iteration 57: 7870319.149 ns/op > Iteration 58: 9764495.575 ns/op > Iteration 59: 10302028.037 ns/op > Iteration 60: 6043169.399 ns/op > Iteration 61: 5523472.362 ns/op > Iteration 62: 4513685.714 ns/op > Iteration 63: 4361806.324 ns/op > Iteration 64: 4388615.079 ns/op > Iteration 65: 4548264.463 ns/op > Iteration 66: 4710752.137 ns/op > Iteration 67: 5688128.866 ns/op > Iteration 68: 6109292.818 ns/op > Iteration 69: 5896914.439 ns/op > Iteration 70: 5986548.913 ns/op > Iteration 71: 6093618.785 ns/op > Iteration 72: 6051450.549 ns/op > Iteration 73: 6237870.056 ns/op > Iteration 74: 5954345.946 ns/op > Iteration 75: 6460748.538 ns/op > Iteration 76: 5929037.634 ns/op > Iteration 77: 6170748.603 ns/op > Iteration 78: 6037382.514 ns/op > Iteration 79: 6156776.536 ns/op > Iteration 80: 5987103.261 ns/op > Iteration 81: 5927080.645 ns/op > Iteration 82: 5914165.775 ns/op > Iteration 83: 6039852.459 ns/op > Iteration 84: 6156798.883 ns/op > Iteration 85: 5902329.787 ns/op > Iteration 86: 5731875.648 ns/op > Iteration 87: 6137622.222 ns/op > Iteration 88: 5926424.731 ns/op > Iteration 89: 5959324.324 ns/op > Iteration 90: 6269630.682 ns/op > Iteration 91: 5720062.176 ns/op > Iteration 92: 5938537.634 ns/op > Iteration 93: 4430361.446 ns/op > Iteration 94: 4498792.683 ns/op > Iteration 95: 5454004.950 ns/op > Iteration 96: 4516479.508 ns/op > Iteration 97: 4382456.349 ns/op > Iteration 98: 4410548.000 ns/op > Iteration 99: 4301657.588 ns/op > Iteration 100: 4438582.329 ns/op > > > Result: 5165386.898 ±(99.9%) 344576.928 ns/op [Average] > Statistics: (min, avg, max) = (4301657.588, 5165386.898, 10302028.037), > stdev = 1015992.919 > Confidence interval (99.9%): [4820809.970, 5509963.825] > > > # VM invoker: > /Library/Java/JavaVirtualMachines/jdk1.7.0_25.jdk/Contents/Home/jre/bin/java > # VM options: -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en > -Duser.variant > # Warmup: 10 iterations, 1 s each > # Measurement: 100 iterations, 1 s each > # Timeout: 10 min per iteration > # Threads: 1 thread, will synchronize iterations > # Benchmark mode: Average time, time/op > # Benchmark: > org.apache.aurora.benchmark.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example > > # Run progress: 50.00% complete, ETA 00:02:14 > # Fork: 1 of 1 > # Warmup Iteration 1: 34499258.065 ns/op > # Warmup Iteration 2: 9519784.483 ns/op > # Warmup Iteration 3: 7017031.847 ns/op > # Warmup Iteration 4: 4898586.667 ns/op > # Warmup Iteration 5: 4924111.607 ns/op > # Warmup Iteration 6: 5391946.341 ns/op > # Warmup Iteration 7: 5405700.980 ns/op > # Warmup Iteration 8: 5138181.395 ns/op > # Warmup Iteration 9: 4860863.436 ns/op > # Warmup Iteration 10: 5076539.171 ns/op > Iteration 1: 4693804.255 ns/op > Iteration 2: 5147288.372 ns/op > Iteration 3: 4809647.826 ns/op > Iteration 4: 6034147.541 ns/op > Iteration 5: 6675740.964 ns/op > Iteration 6: 5156481.308 ns/op > Iteration 7: 4678330.508 ns/op > Iteration 8: 4775528.139 ns/op > Iteration 9: 4800773.913 ns/op > Iteration 10: 4623054.393 ns/op > Iteration 11: 4816021.834 ns/op > Iteration 12: 4597212.500 ns/op > Iteration 13: 4691842.553 ns/op > Iteration 14: 4720820.513 ns/op > Iteration 15: 4662227.848 ns/op > Iteration 16: 5261447.619 ns/op > Iteration 17: 4840087.719 ns/op > Iteration 18: 4726081.197 ns/op > Iteration 19: 4673974.576 ns/op > Iteration 20: 5129837.209 ns/op > Iteration 21: 4724444.444 ns/op > Iteration 22: 4740678.112 ns/op > Iteration 23: 4710260.684 ns/op > Iteration 24: 4789688.312 ns/op > Iteration 25: 4589266.667 ns/op > Iteration 26: 4675394.068 ns/op > Iteration 27: 4594887.500 ns/op > Iteration 28: 4642579.832 ns/op > Iteration 29: 4666215.190 ns/op > Iteration 30: 4916044.444 ns/op > Iteration 31: 4734978.541 ns/op > Iteration 32: 4527586.066 ns/op > Iteration 33: 4695753.191 ns/op > Iteration 34: 4675682.203 ns/op > Iteration 35: 4598608.333 ns/op > Iteration 36: 4616338.912 ns/op > Iteration 37: 4722192.308 ns/op > Iteration 38: 5385243.902 ns/op > Iteration 39: 5183159.624 ns/op > Iteration 40: 4802855.895 ns/op > Iteration 41: 5393404.878 ns/op > Iteration 42: 7052592.357 ns/op > Iteration 43: 6087237.569 ns/op > Iteration 44: 6829685.185 ns/op > Iteration 45: 6105154.696 ns/op > Iteration 46: 5331869.565 ns/op > Iteration 47: 4765870.690 ns/op > Iteration 48: 4635117.155 ns/op > Iteration 49: 4882526.549 ns/op > Iteration 50: 4883402.655 ns/op > Iteration 51: 5018100.000 ns/op > Iteration 52: 4899177.778 ns/op > Iteration 53: 5568404.040 ns/op > Iteration 54: 4912208.889 ns/op > Iteration 55: 5073077.982 ns/op > Iteration 56: 5441458.128 ns/op > Iteration 57: 4964382.883 ns/op > Iteration 58: 5379580.488 ns/op > Iteration 59: 4925330.357 ns/op > Iteration 60: 5111805.556 ns/op > Iteration 61: 5226265.403 ns/op > Iteration 62: 5304846.154 ns/op > Iteration 63: 4920982.222 ns/op > Iteration 64: 4905186.667 ns/op > Iteration 65: 4970238.739 ns/op > Iteration 66: 5002425.339 ns/op > Iteration 67: 4842846.491 ns/op > Iteration 68: 5543889.447 ns/op > Iteration 69: 4828794.760 ns/op > Iteration 70: 4809737.991 ns/op > Iteration 71: 5151565.421 ns/op > Iteration 72: 5077170.507 ns/op > Iteration 73: 4987425.339 ns/op > Iteration 74: 4888584.071 ns/op > Iteration 75: 4980319.820 ns/op > Iteration 76: 5075321.101 ns/op > Iteration 77: 4719508.547 ns/op > Iteration 78: 4932200.893 ns/op > Iteration 79: 5046264.840 ns/op > Iteration 80: 4835530.702 ns/op > Iteration 81: 4855162.996 ns/op > Iteration 82: 4814104.803 ns/op > Iteration 83: 4650232.068 ns/op > Iteration 84: 5211075.472 ns/op > Iteration 85: 4970504.505 ns/op > Iteration 86: 4776272.727 ns/op > Iteration 87: 4929089.286 ns/op > Iteration 88: 5063995.413 ns/op > Iteration 89: 5059706.422 ns/op > Iteration 90: 5042342.466 ns/op > Iteration 91: 4760637.931 ns/op > Iteration 92: 5009213.636 ns/op > Iteration 93: 5985075.676 ns/op > Iteration 94: 4735798.283 ns/op > Iteration 95: 4893389.381 ns/op > Iteration 96: 6055005.495 ns/op > Iteration 97: 4684194.915 ns/op > Iteration 98: 4649130.252 ns/op > Iteration 99: 4619602.510 ns/op > Iteration 100: 4593595.833 ns/op > > > Result: 5011738.309 ±(99.9%) 160249.620 ns/op [Average] > Statistics: (min, avg, max) = (4527586.066, 5011738.309, 7052592.357), > stdev = 472499.654 > Confidence interval (99.9%): [4851488.689, 5171987.930] > > > # Run complete. Total time: 00:04:29 > > Benchmark > Mode Samples Score Error Units > o.a.a.b.SchedulingBenchmarks.ConstraintMismatchsSchedulingBenchmark.example > avgt 100 5165386.898 ± 344576.928 ns/op > o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.example > avgt 100 5011738.309 ± 160249.620 ns/op > ``` > > > Thanks, > > Maxim Khutornenko > >
