----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review64919 -----------------------------------------------------------
This is *awesome*. Using docker to do aurora builds in and to ship an aurora runtime is fantastic. My major issue with this commit is that you're unnecessarily putting build dependencies (aurora source, python-dev, git, etc) into a runtime container. I suggest a slightly different approach than you've taken here: there should be two Dockerfiles: one for build and one for runtime. Also, I don't think they should be examples, let's hook docker up to the CI process and ship a runnable docker image for every commit of aurora! The build Dockerfile should produce a docker image which we can run the build in. It will contain all build time dependencies (gradle, python-dev, etc). When a developer wants to do the build they will simply run "docker run aurora/build" This will use volume mounts to import the code into the container and will write out a number of jar and pex files back to the developer's workspace. This is really useful because now we have a programatic way (in the Dockerfile) to express *all* build time dependencies. To build a runtime container, we ship another Dockerfile which installs all the runtime deps (java 1.7, etc) and uses Dockerfile's ADD to copy the jar and pex files from the developer's workspace into the container. We run build this docker container on every commit through a CI process and ship it to a docker registry. Then to run, users just have to do "docker run aurora/aurora" - Jay Buffington On Dec. 11, 2014, 6:32 p.m., Tony Dong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28198/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 6:32 p.m.) > > > Review request for Aurora, Benjamin Staffin, Kevin Sweeney, Bill Farner, and > Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Add an example on how to build with Docker. > > > Diffs > ----- > > README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d > examples/docker/Dockerfile PRE-CREATION > > Diff: https://reviews.apache.org/r/28198/diff/ > > > Testing > ------- > > > Thanks, > > Tony Dong > >
