> On Dec. 19, 2014, 6:25 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/common/transport.py, lines 44-45 > > <https://reviews.apache.org/r/29165/diff/3/?file=795507#file795507line44> > > > > does it make sense to have both session_factory and user_agent as > > arguments to TRequestsTransport if user_agent just gets passed directly to > > the session_factory anyway? seems like it would be better to facilitate > > the population of a user-agent by passing a custom session_factory. > > Kevin Sweeney wrote: > +1 > > Joshua Cohen wrote: > I went back and forth on this. My thinking was the default session > factory might do work that we wouldn't want to replicate everywhere that we > want to pass in a custom user agent. > > How would you feel if instead of passing the user agent to the session > factory, we explicitly set the user agent on the returned session if the > header is not already present? > > Brian Wickman wrote: > This sounds fine to me.
Ok, done! - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29165/#review65644 ----------------------------------------------------------- On Dec. 19, 2014, 7:39 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29165/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2014, 7:39 p.m.) > > > Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian > Wickman. > > > Bugs: AURORA-934 > https://issues.apache.org/jira/browse/AURORA-934 > > > Repository: aurora > > > Description > ------- > > Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients. > > > Diffs > ----- > > src/main/python/apache/aurora/client/BUILD > 2a66825426923fd7e5b7c70101747bc292208e19 > src/main/python/apache/aurora/client/api/__init__.py > 9977b419b58bbe2c7f860b1c6ffde6d1a791a05d > src/main/python/apache/aurora/client/api/command_runner.py > 4d8f0107ed6766603cb44a6b231de6cc44c3df4b > src/main/python/apache/aurora/client/api/scheduler_client.py > 4ae18f01380893d842674077d98caca135f7d233 > src/main/python/apache/aurora/client/base.py > a897e879dfda7340d7561247d3fa7cda2dbb5bc6 > src/main/python/apache/aurora/client/cli/context.py > b1ffc05ebd520e91be58704615c5a12c62e75f03 > src/main/python/apache/aurora/client/commands/BUILD > f2564839ea782b9b2492afb37756db3f0e7fa2ac > src/main/python/apache/aurora/client/commands/admin.py > 4b86c5a5851206d875f07c9afa9d68a8f57f5ab7 > src/main/python/apache/aurora/client/commands/core.py > 7b970e8872c73a30947ce8f407c37da3d06f20df > src/main/python/apache/aurora/client/commands/ssh.py > b0916edb0f90906e07a80302473ae7a7446f62a9 > src/main/python/apache/aurora/client/factory.py > 4b31e8503938a3f2af2c2d2a9a7c812cd489fa65 > src/main/python/apache/aurora/common/transport.py > 76e079ac4c0e7a678af7b1c38ea1398b24ce5e53 > src/test/python/apache/aurora/client/api/test_scheduler_client.py > b3232e9b00075c8429230fdf4858d039d3df4e36 > src/test/python/apache/aurora/client/cli/test_diff.py > 95c7c92942c7cbde344a093789b3e04b63200cc5 > src/test/python/apache/aurora/client/commands/test_admin.py > c7d970c805e7e56f9ecce159c93cd2dac14d1fca > src/test/python/apache/aurora/client/commands/test_admin_sla.py > 74fc79c23b4718fe0e1bc921c77533ac12c7d085 > src/test/python/apache/aurora/client/commands/test_create.py > d7c32b368605d14c55e87eb6e6cc04d83a8ef406 > src/test/python/apache/aurora/client/commands/test_diff.py > b48b53d3282d25c74a8424efe15ad19493acb3a5 > src/test/python/apache/aurora/common/test_transport.py > 2045f64eac638fbdccf59e7971d23b8854972654 > > Diff: https://reviews.apache.org/r/29165/diff/ > > > Testing > ------- > > ./pants build src/test/python/apache/aurora:: > > Also ran e2e tests for v1 and v2 and verified the user agent in the scheduler > logs. > > > Thanks, > > Joshua Cohen > >
