> On Dec. 29, 2014, 8:36 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/LocalServiceRegistryWithOverrides.java, > > line 21 > > <https://reviews.apache.org/r/29464/diff/1/?file=802787#file802787line21> > > > > Convention is to place CmdLine Args in Guice Modules (to separate > > wiring from implementation). Also, this value will need to be plumbed into > > the mesos Log somehow. > > Steve Niemitz wrote: > Ok cool, I can make that change. > > Steve Niemitz wrote: > Also can you explain more what you mean by "plumbed into the mesos Log > somehow"? > > Kevin Sweeney wrote: > When running multiple schedulers they need to communicate with each other > to coordinate writes to the Mesos replicated log. They do this by advertising > their IP address in zookeeper. Part of that: the scheduler IP (actually > libprocess PID, which contains the scheduler IP) is written to a znode under > (the value of -native_log_zk_group_path).
Ah ok I understand now. The intention of this patch was more for ease of use for external clients (eg I'm not able to resolve EC2 internal IPs). Do you think this needs to change as well? I'm hesitant to change it since I haven't seen any issues with it as-is. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29464/#review66297 ----------------------------------------------------------- On Dec. 29, 2014, 8:23 p.m., Steve Niemitz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29464/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2014, 8:23 p.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > I've added a new flag for the aurora scheduler, -dns_name_override which can > override the scheduler server address published into ZK. > > This is useful for cases such as running the scheduler in EC2, where the > autodetected local address is actual an interal IP and not the public address > of the machine. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 72c7545e7f16549f6a9ccb5fb74a06f154a7ea94 > > src/main/java/org/apache/aurora/scheduler/configuration/LocalServiceRegistryWithOverrides.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java > cf173850635572c0df38bdd5cb14de8ce2016bf7 > src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java > c3bf5ea4cbeaad03e187f84215b86531d55c25b3 > > Diff: https://reviews.apache.org/r/29464/diff/ > > > Testing > ------- > > > Thanks, > > Steve Niemitz > >
