----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29696/#review67159 -----------------------------------------------------------
Ship it! Master (9a817f2) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 8, 2015, 2:19 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29696/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 2:19 a.m.) > > > Review request for Aurora, Kevin Sweeney and Zameer Manji. > > > Bugs: AURORA-990 > https://issues.apache.org/jira/browse/AURORA-990 > > > Repository: aurora > > > Description > ------- > > In the course of this, i took a stab at cleaning up the unit test to remove > unnecessary mocking and avoid writing to a temporary file. The nice outcome > of the mock removal is that the job configuration in our code is identical to > what would appear in a configuration file. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/__init__.py > 395819fdf24b7919b32be51060fb5b581c8e1514 > src/main/python/apache/aurora/client/cli/jobs.py > 744d53405081e75b9aedcdcb7e4a823a2e0e743f > src/test/python/apache/aurora/client/cli/test_inspect.py > 1c07d912c95eafa292d5451f4d6c72e9a711dae0 > > Diff: https://reviews.apache.org/r/29696/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
