> On Jan. 15, 2015, 6:55 p.m., Joshua Cohen wrote: > > Any reason why the times in the output seem to be off by 2 minutes? (i.e. > > it says last diff was at 20:18, but looking at the review it was actually > > at 20:20?) > > Bill Farner wrote: > Great question. These are two different timestamps. One is for the diff > (which you see in the output of the script), and one is for the change made > to the review (displayed on RB). You can see both of these here: > ``` > $ curl -s https://reviews.apache.org/api/review-requests/28920/changes/ | > python -mjson.tool | head -n54 > { > "changes": [ > { > "fields_changed": { > "commit_id": { > "new": [ > "35da9b53c5fc15e246e4f3dd651c4e5330a26f29" > ], > "old": [ > "3e4809f9854f8c20b158a722ac14c9e570fa4b7f" > ] > }, > "diff": { > "added": { > "base_commit_id": > "a350982ee63b70eefdb182274946c2c3c8789509", > "basedir": "", > "extra_data": {}, > "id": 55807, > "links": { > "files": { > "href": > "https://reviews.apache.org/api/review-requests/28920/diffs/16/files/";, > "method": "GET" > }, > "repository": { > "href": > "https://reviews.apache.org/api/repositories/133/";, > "method": "GET", > "title": "aurora" > }, > "self": { > "href": > "https://reviews.apache.org/api/review-requests/28920/diffs/16/";, > "method": "GET" > }, > "update": { > "href": > "https://reviews.apache.org/api/review-requests/28920/diffs/16/";, > "method": "PUT" > } > }, > "name": "diff", > "revision": 16, > "timestamp": "2015-01-14T20:18:13Z" > } > } > }, > "id": 46089, > "links": { > "self": { > "href": > "https://reviews.apache.org/api/review-requests/28920/changes/46089/";, > "method": "GET" > } > }, > "text": "", > "text_type": "markdown", > "timestamp": "2015-01-14T20:20:15Z" > }, > ``` > > I believe the delta is caused by the delay between when the diff was > posted and the publish button was clicked.
Gotcha, thanks for clarifying. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29940/#review68291 ----------------------------------------------------------- On Jan. 15, 2015, 6:38 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29940/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 6:38 p.m.) > > > Review request for Aurora and Steve Niemitz. > > > Bugs: AURORA-1018 > https://issues.apache.org/jira/browse/AURORA-1018 > > > Repository: aurora > > > Description > ------- > > Paginate when necessary in review bot. > > > Diffs > ----- > > build-support/jenkins/review_feedback.py > 66a887797993e2d2d4301ce95242559bfed22c0d > > Diff: https://reviews.apache.org/r/29940/diff/ > > > Testing > ------- > > Ran locally. Review bot is not currently interested in building > https://reviews.apache.org/r/28920/ > > ``` > Inspecting review 28920: Add support for docker containers to aurora > Request: https://reviews.apache.org/api/review-requests/28920/reviews/ > Fetching next page of reviews. > Request: > https://reviews.apache.org/api/review-requests/28920/reviews/?start=25&max-results=25 > Fetching next page of reviews. > Request: > https://reviews.apache.org/api/review-requests/28920/reviews/?start=50&max-results=25 > Feedback has been given 39 times > Request: https://reviews.apache.org/api/review-requests/28920/diffs/ > Latest feedback was given at 2015-01-15T17:57:08Z > Latest build request from a user at 2015-01-15T17:57:08Z > Latest diff was posted at 2015-01-14T20:18:13Z > ``` > > > Thanks, > > Bill Farner > >
