----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/#review72030 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java <https://reviews.apache.org/r/30891/#comment117964> The cohesion of the HostOffer class seems to be rather low. The new field `staticallyBannedOffers` has not much in common with the other members. We might improve this situation by performing the `isStaticallyBanned` check within an overload of the `getWeaklyConsistentOffers` method. - Stephan Erb On Feb. 11, 2015, 9:38 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30891/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 9:38 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-909 > https://issues.apache.org/jira/browse/AURORA-909 > > > Repository: aurora > > > Description > ------- > > Offer filtering for static vetoes. Part 3 of 4: Filtering out statically > banned offers. > > Will not apply cleanly: diffed with https://reviews.apache.org/r/30890 as a > parent. > > Original RB: https://reviews.apache.org/r/28617/ > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java > f66383830140e5eaba436f35ebb5192eee65947a > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java > ce47ff152e303fd2116bc3b9e91c0c1a8f76f258 > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java > e1c29747c9854cf75bf63f6f085cf40ca68989af > src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java > 4cf602ad32b972c18eb5a81e9b2f59c67859bdb2 > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java > 5647349854a5e04de749c4d809684a0066d4da06 > src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java > 6cc13231560996b144101eba36577f49017aba06 > > Diff: https://reviews.apache.org/r/30891/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
