> On Feb. 13, 2015, 12:41 a.m., David McLaughlin wrote: > > docs/thrift-deprecation.md, line 20 > > <https://reviews.apache.org/r/29117/diff/4/?file=862696#file862696line20> > > > > Sorry I missed this first review, but AFAIK this isn't true for dynamic > > languages (incl. our own scheduler UI)?
Can you elaborate? The above statement assumes renaming the field throughout the codebase (including java, python and JS). Current +- 1 versions of client will still be able to communicate with the scheduler. UI ships with the scheduler and thus will not have the renaming problelm. What am I missing? - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/#review72291 ----------------------------------------------------------- On Feb. 13, 2015, 12:35 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29117/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 12:35 a.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-973 > https://issues.apache.org/jira/browse/AURORA-973 > > > Repository: aurora > > > Description > ------- > > This is a first stab at documenting thrift deprecation. Any > suggestions/comments are welcome. > > > Diffs > ----- > > docs/developing-aurora-client.md e002d908ce07020513fa06c7e70c41f9e2f55b1d > docs/developing-aurora-scheduler.md > 7f6cc2e6c8e01115a9b7a7dc7633bcd88ba02a0f > docs/thrift-deprecation.md PRE-CREATION > > Diff: https://reviews.apache.org/r/29117/diff/ > > > Testing > ------- > > https://github.com/maxim111333/incubator-aurora/blob/populated_deprecation/docs/thrift-deprecation.md > > > Thanks, > > Maxim Khutornenko > >
