----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74373 -----------------------------------------------------------
src/main/python/apache/thermos/monitoring/garbage.py <https://reviews.apache.org/r/31491/#comment120938> Optional, but you'd be doing FutureOncallJoe™ a favor by bootstrapping a logger and printing out the rm-s here (maybe in the lower methods instead?0 src/test/python/apache/thermos/monitoring/test_garbage.py <https://reviews.apache.org/r/31491/#comment120939> If these are going to run in CI, we shouldn't add 'real' disk unfortunately. This could roll up into an 'integration' test, but I'm not a fan of adding a disk dependency to the tests - Joe Smith On Feb. 26, 2015, noon, Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31491/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2015, noon) > > > Review request for Aurora, Joshua Cohen and Stephan Erb. > > > Bugs: AURORA-1155 > https://issues.apache.org/jira/browse/AURORA-1155 > > > Repository: aurora > > > Description > ------- > > Add basic test coverage to the TaskGarbageCollector. > > > Diffs > ----- > > src/main/python/apache/thermos/monitoring/garbage.py > 53bb0345f963ae168206f34af1d82c67427f41fe > src/test/python/apache/thermos/monitoring/BUILD > 9c267775080e0bde08ff4e9b01862c6bee187634 > src/test/python/apache/thermos/monitoring/test_garbage.py PRE-CREATION > > Diff: https://reviews.apache.org/r/31491/diff/ > > > Testing > ------- > > ./pants test src/test/python/apache/thermos/monitoring:test_garbage > > > Thanks, > > Brian Wickman > >
