> On March 7, 2015, 12:01 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, > > line 101 > > <https://reviews.apache.org/r/31814/diff/1/?file=888014#file888014line101> > > > > nit: s/>p/<p
Fixed. > On March 7, 2015, 12:01 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, > > line 200 > > <https://reviews.apache.org/r/31814/diff/1/?file=888014#file888014line200> > > > > The original scope for AURORA-1077 was to allow for passing a message > > along with pause/abort RPCs (so we can, e.g., associate some additional > > data with a pause caused by an external service monitoring an update). > > > > Unless I'm missing something, I don't see that support here. Is that > > planned for a subsequent review, or has that requirement been missed? Yes, i'm trying to reasonably scope the reviews to avoid dropping code bombs on reviewers. > On March 7, 2015, 12:01 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/updater/SideEffect.java, line 36 > > <https://reviews.apache.org/r/31814/diff/1/?file=888016#file888016line36> > > > > restore newline, remove leading space. Fixed. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31814/#review75573 ----------------------------------------------------------- On March 6, 2015, 11:29 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31814/ > ----------------------------------------------------------- > > (Updated March 6, 2015, 11:29 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1077 > https://issues.apache.org/jira/browse/AURORA-1077 > > > Repository: aurora > > > Description > ------- > > Include messages with internal job updater state transitions. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java > 09f2a74c9e6f6dbf79f83aa7a387587c593b9f0e > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java > acdade3dca807a221b4da975d0310c91884ee752 > src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java > 27a5b9026f5ac3b3bdeb32813b10435bc3dab173 > src/main/java/org/apache/aurora/scheduler/updater/SideEffect.java > 27e0654bfb90f48b407edda5a0c914e595d9c552 > src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java > 66b0e4b7a9b23e3e6c772a21f5adc39e1d1461ad > src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java > 4db0080547d61af1511a4fb62bf88b3bbf819f1e > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > e24d6bde5f3479a75522e825cce4ec6c30c117aa > src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java > 7d0a7438b4a517e5e0d44f4e99aceb1a6d19f987 > > Diff: https://reviews.apache.org/r/31814/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >