----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32014/#review76332 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java <https://reviews.apache.org/r/32014/#comment123873> `Tasks.ids(activeTasks)` src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java <https://reviews.apache.org/r/32014/#comment123874> This is a pretty weird log entry to have. Can it be done in the client instead? src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java <https://reviews.apache.org/r/32014/#comment123875> Ditto - this really seems like it should be client-side logging. The client gets back the actiosn that were taken, seems like it has all the info it needs to check for discrepancies. - Bill Farner On March 13, 2015, 1:23 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32014/ > ----------------------------------------------------------- > > (Updated March 13, 2015, 1:23 a.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Also added missing test coverage. > > > Diffs > ----- > > config/legacy_untested_classes.txt 06e130fae6bdc43b5e8aff182a530eac65acca53 > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java > b6f642e319b790544bc538098e7cb78b1bb49997 > > src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java > bd031a5e0b7d2923e36ca5958c5074f40dc64848 > > Diff: https://reviews.apache.org/r/32014/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >